Topic: Calling functions from modules [solved]

[Revae]

I have a save gui I'm working on.  All the code works fine from inside the global script, but I'd rather have my code somewhat cleaner than that (I say somewhat because I'm more an artist than a coder and it's pretty messy all over as is).

Anyway.  I understand that you have to import the scripts from the header files of each script (I've read other posts on this), but I'm having a hard time figuring out how to call the button functions from the script.  My save gui script looks like this:

Code: Adventure Game Studio

1. int SavSel=0;
2.  
3. //Funks//
4. function btnClsSavLd_OnClick(GUIControl *control, MouseButton button){
5. gSaveGameScreen.Visible = false;
6. gJournal.Visible=true;
7. }
8.  
9. function btnSelSlt1_OnClick(GUIControl *control, MouseButton button){
10. btnSelSltA.NormalGraphic=1552;
11.  
12. btnSelSlt2.NormalGraphic=1552;
13.  
14. btnSelSlt3.NormalGraphic=1552;
15.  
16. btnSelSlt1.NormalGraphic=1554;
17.  
18. SavSel=1;
19. }
20.  
21. function btnSelSlt2_OnClick(GUIControl *control, MouseButton button){
22. btnSelSltA.NormalGraphic=1552;
23.  
24. btnSelSlt1.NormalGraphic=1552;
25.  
26. btnSelSlt3.NormalGraphic=1552;
27.  
28. btnSelSlt2.NormalGraphic=1554;
29.  
30. SavSel=2;
31. }
32.  
33. function btnSelSlt3_OnClick(GUIControl *control, MouseButton button){
34. btnSelSltA.NormalGraphic=1552;
35.  
36. btnSelSlt2.NormalGraphic=1552;
37.  
38. btnSelSlt1.NormalGraphic=1552;
39.  
40. btnSelSlt3.NormalGraphic=1554;
41.  
42. SavSel=3;
43. }
44.  
45. function btnSelSltA_OnClick(GUIControl *control, MouseButton button){
46. btnSelSlt1.NormalGraphic=1552;
47.  
48. btnSelSlt2.NormalGraphic=1552;
49.  
50. btnSelSlt3.NormalGraphic=1552;
51.  
52. btnSelSltA.NormalGraphic=1554;
53.  
54. SavSel=4;
55. }
56.  
57.  
58. function btnSave_OnClick(GUIControl *control, MouseButton button){
59.   if (SavSel==1){
60.   gJournal.Visible=false;
61.   SaveGameSlot(1, "Save 1");
62.   gSaveGameScreen.Visible=false;
63.   }
64.  
65.   if (SavSel==2){
66.   gJournal.Visible=false;
67.   SaveGameSlot(2, "Save 2");
68.   gSaveGameScreen.Visible=false;
69.   }
70.  
71.   if (SavSel==3){
72.   gJournal.Visible=false;
73.   SaveGameSlot(3, "Save 3");
74.   gSaveGameScreen.Visible=false;
75.   }
76.  
77.   if (SavSel==4){
78.   gJournal.Visible=false;
79.   SaveGameSlot(4, "Auto Save");
80.   gSaveGameScreen.Visible=false;
81.   }
82.  
83.   else{
84.  
85.   }
86. }
87.  
88.  

What would I put in the header file, and how would I call the functions from the global file?  Thanks in advance!

Edit:  Alright. Solved in the very next post.  Thanks Khris.

[Khris]

Unfortunately, the handler functions for buttons and other GUI elements have to be in the global script.

However, you can move the contents to a module, and you don't need a separate function for each button. That's pretty tidy at least.
You can handle all clicks in one function or group them in a logical way by using the control parameter:

Code: Adventure Game Studio

1. // GlobalScript.asc
2.  
3. // this handles all three slot clicks
4. function btnSelSlt_OnClick(GUIControl *control, MouseButton button) {
5.   // call module function:
6.   MySaveGame.ClickSlot(control.AsButton);
7. }

Now paste "btnSelSlt_OnClick" into all buttons' event properties.

The module would look like this:

Code: Adventure Game Studio

1. // header
2.  
3. struct MySaveGame {
4.   import static void ClickSlot(Button* slot);
5. };
6.  
7. // main script
8.  
9. static void MySaveGame::ClickSlot(Button* slot) {
10.   int i = 2;   // first button's ID: 2
11.   while (i <= 4) {   // third button's ID: 4
12.     Button* b = gSaves.Controls[i].AsButton;
13.     if (b.ID == slot) b.NormalGraphic = 1554;
14.     else b.NormalGraphic = 1552;
15.     i++;
16.   }
17.   SaveSel = slot.ID - 1;     // (ID: 2 - 4: -> slot 1 - 3)
18. }

[Revae]

Snap.  That's pretty tricky.  The code you suggested makes about half-sense to me though since I'm muddling through this.  I only partially understand was a struct is, and I don't know what * means in this context (though I plan on looking it up).  I also don't understand why you started counting at 2 instead of 1.

But I can definitely get it to work, even with my limited capabilities, thanks to you.  So...  Thanks.  To you. 

I may see if I can enlist the help of a scripter in the future because, while I can knock out art pieces all day, learning the scripting along the way has really taken a toll on my time.

[Khris]

You don't really need a struct here; I just like to group my module functions by naming them "Module.Command()", and you need to make them struct members for that.
You can do this instead:

Code: Adventure Game Studio

1. // header
2. import void DoSomething(int param);   // make function accessible by other scripts
3.  
4. // main module script
5. void DoSomething(int param) {
6.   Display("The parameter is: %d", param);
7. }

The * is needed because instead of a datatype like int or String which holds a discrete value like 5 or "Hello", I'm declaring a so-called pointer, a variable pointing to a script object (in this case a GUIButton).

I started counting at 2 as an example; ID's 0 and 1 could've been used by a label and a close-gui button for instance.
You can see the ID of the GUI elements in the dropdown menu where you can select them in order to edit them.
Also, computers usually start counting at 0, not 1. Whenever you're creating a GUI with several similar GUIControls (save slots, telephone keys, etc.) you should plan the numbering from the beginning.