STEVE PLEASE VALIDATE THAT THIS CODE IS OK

Started by Crimson Wizard, Wed 13/06/2012 20:14:27

Previous topic - Next topic

Crimson Wizard

... a shout made years ago reached my ears today.

AGS code, acroom.h:
Code: "acroom.h"

void ViewLoopNew::ReadFromFile(FILE *iii)
{
#ifdef ALLEGRO_BIG_ENDIAN

  STEVE PLEASE VALIDATE THAT THIS CODE IS OK


Well, of course it is not OK; I never met a compiler that would understand such instruction.
And whoever is Steve, he did not even bother...




(laugh) :=

Ghost

My sister's friend's uncle Steve* validates that the code IS okay. Stop worrying and start breaking your eggs on the right side  (nod)

___
* Stefan, actually.

Calin Leafshade

That is almost certainly a reference to Steve McCrea aka Kweepa with regards to the PPC Mac port.

monkey0506

Calin, don't try to hide the fact that your name is Steve. :P

Kweepa

Stupid PPC mac port.
I don't remember this code...
I don't recognize this code...
Look! A flame-haired journaliste on a police horse!
Still waiting for Purity of the Surf II

Ghost


BigMc

I bet that line was written by should-have-gone-to-bed-a-long-time-ago Steve. Should better have left a Post-it for regular Steve. :-D

timofonic

And this is one of the little examples about the reasons AGS code needs massive refactoring.

Did you grep the code for insults too? Let's compare it with the Linux kernel! :D

Calin Leafshade

I'm not sure you fully understand the use of the word "refactoring"

timofonic

#9
Quote from: Calin Leafshade on Fri 15/06/2012 08:11:12
I'm not sure you fully understand the use of the word "refactoring"

Yes, I'm aware of some computer programming terminology. Here are some references to stuff I did read about...

http://en.wikipedia.org/wiki/Code_refactoring
http://en.wikipedia.org/wiki/Code_smell
http://en.wikipedia.org/wiki/Anti-pattern

SMF spam blocked by CleanTalk