[FEATURE REQUEST] Option to add delay for frames when assigning Sprites to View

Started by Gal Shemesh, Wed 06/09/2023 16:11:17

Previous topic - Next topic

Gal Shemesh

The ability to grab a bulk of sprites in the Sprite editor and to assign them to a View is a very neat feature. Though, it lacks the ability to set a 'delay' to all of the frames if you need it.

In the game I'm working on, I need the walk animation of my character to run in an 'in-between' delay speed, which I can achieve only by setting a delay value for every frame of its walking animations. But since every of the 8 direction of my characters contains 18 walking frames, this is quite tedious to have to click on each and every frame in every loop for adding the delay value. So it could be nice if it could be added for all frames at the same process of assigning them to a view.

Thanks
Gal Shemesh,
goldeng

Crimson Wizard

I guess this is a matter of supporting multiple selection in the view editor, which would allow to change properties for multiple frames at once?

Opened a ticket:
https://github.com/adventuregamestudio/ags/issues/2124

Gal Shemesh

I'm not sure if I understood correctly what you mean. The Sprites editor lets me select multiple selection and I use this to assigning the selection to a view. It gives options such as overwriting or adding the frames to an existing loop, and also to set all frames as flipped or to add them in reverse order. I only find that it missing one option which is to set a certain delay for all the frames in this process.

EDIT:
Sorry, I mistook the Sprite and the View editor when I read your reply. I originally talked about the Sprite editor so the delay could be set at the same time when assigning the frames to a View. But if as you said the View editor will allow selecting of multiple frames that could do the trick as well, in addition to also allow deleting / flipping of multiple frames.
Gal Shemesh,
goldeng

Crimson Wizard

Quote from: Gal Shemesh on Wed 06/09/2023 16:45:46The Sprites editor lets me select multiple selection and I use this to assigning the selection to a view. It gives options such as overwriting or adding the frames to an existing loop, and also to set all frames as flipped or to add them in reverse order. I only find that it missing one option which is to set a certain delay for all the frames in this process.

I did not remember that this process let you choose "flipped" already.

I guess that both things may be worth adding for convenience.

Adding a "delay" option to sprite paste dialog will probably be much easier to do, but multiple selection in view editor is a must have regardless, because oftentimes people need to adjust their animations after import.

EDIT: Oh, I see, so the situation is more confusing.
Apparently there are TWO separate methods for importing view frames. There's a context menu command + dialog in Sprite Manager called "Assign to View", and a separate context command in a View editor itself. And they have different capabilities....
The "Assign to View" can assign only to the first 8 loops for some reason.
This is such a mess...

Gal Shemesh

Thanks a lot, CW. If and when this could be added that would be much appreciated.

Quote from: Crimson Wizard on Wed 06/09/2023 17:05:09The "Assign to View" can assign only to the first 8 loops for some reason.
This is such a mess...
Gee, good find! I haven't reached to assign to a 9th loop yet but only to the 8 directions. You were one step ahead of me on this one before I even managed to find and report about it myself, as I counted on assigning sprites this way... (laugh) Thanks for letting me know at least. :)
Gal Shemesh,
goldeng

Crimson Wizard

Well, I did an experimental version that allows multiple frames selection using Ctrl+Click and Shift+Click, based on 3.6.1:
https://github.com/adventuregamestudio/ags/pull/2127

Unfortunately, there's something wrong with out build server again, so I made a manual build for testing:
https://www.dropbox.com/scl/fi/b3h3w3oxdwhfe4cuve5xr/361-multiviewframeselect.zip?rlkey=hckjbxjfozq7fsn7nd9xzm8qg&dl=0

Gal Shemesh

That is awesome, CW. What an improvement to the View editor! Thank you so much! I can confirm that delaying , flipping, setting different images and setting a sound on frames in multiple loops work great!

I have some feedback for other things I checked that don't currently work correctly:

1. Upon trying to delete (Del Key) a selection of frames in multiple loops, only the frames of the first loop are getting deleted while the selected frames on different loops remain intact.

2. The right-click context menu on any of the frames from the multiple selection removes the multiple selection and affects only the single frame clicked upon.
Gal Shemesh,
goldeng

Crimson Wizard


Gal Shemesh

Gal Shemesh,
goldeng

Crimson Wizard

Is there anyone else interested in testing this? Based on my tests this is generally working, but I may be missing something.
Explanation and instructions are here:
https://github.com/adventuregamestudio/ags/pull/2127

Download build:
https://www.dropbox.com/scl/fi/b3h3w3oxdwhfe4cuve5xr/361-multiviewframeselect.zip?rlkey=hckjbxjfozq7fsn7nd9xzm8qg&dl=0

If everything is fine, I would merge this, and this will be a part of the next 3.6.1 beta soon.
Then again, i might add this, and fix any problems later.

Crimson Wizard

So, multiple frame selection has been added in 3.6.1 editor, but the discrepancy between menu commands for inserting sprites into views was not addressed yet. This is still something to check out, but maybe lower priority now.

SMF spam blocked by CleanTalk