Adventure Game Studio | Forums

AGS Development => Editor Development => Topic started by: Laura Hunt on 25 Jan 2021, 21:05

Title: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Laura Hunt on 25 Jan 2021, 21:05
I would like to make some small suggestions that might hopefully bring some quality-of-life improvements to working with frame-linked audio:

1) Having some kind of visual indicator for frames with linked audio, like a simple dot above the frame, or an "x", or a music note symbol, or something of the sort, would make it so much easier to identify at a quick glance which frames have audio linked to them, something that can be a huge nuisance when you have views with a lot of long loops and you need to find that *one* frame with a specific audio clip.

2) More engine- than editor-related, but having the audioclip DefaultVolume property be accessible and modifiable by script would be incredibly useful; for example, to be able to easily do fading footsteps, among many other situations.

3) Maybe this one is a bit more complicated, but would it be possible to make it so that, when an animation is played in the preview panel, the frame-linked audioclips play too?
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Crimson Wizard on 25 Jan 2021, 22:09
2) More engine- than editor-related, but having the audioclip DefaultVolume property be accessible and modifiable by script would be incredibly useful; for example, to be able to easily do fading footsteps, among many other situations.

Is this related to not being able to configure frame audio's volume when it starts? If so, perhaps it would be better to find a direct solution to that.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Laura Hunt on 26 Jan 2021, 07:59
2) More engine- than editor-related, but having the audioclip DefaultVolume property be accessible and modifiable by script would be incredibly useful; for example, to be able to easily do fading footsteps, among many other situations.

Is this related to not being able to configure frame audio's volume when it starts? If so, perhaps it would be better to find a direct solution to that.

I wasn't aware that this was being looked into, but yes, that approach would also fix the issue.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Crimson Wizard on 26 Jan 2021, 14:42
Well, I would not say it's looked into right now (unless I am not aware of that), but it seems more natural to be able to setup how the frame trigger plays the sound rather than modify original clip's properties.

Ofcourse original clip may also be made modifiable, because why not, the property is just a number, but it feels like a wrong solution for the frame sound problem.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: eri0o on 18 Sep 2021, 22:13
I briefly played with adding an indicator for audio in the frame

(https://i.imgur.com/S3nKrUf.png)

Wonder if it's alright or too subtle. I used the existing icon for audio.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Laura Hunt on 18 Sep 2021, 22:18
I briefly played with adding an indicator for audio in the frame
Wonder if it's alright or too subtle. I used the existing icon for audio.

Hey, that looks really cool! I personally would be totally ok with this icon, it's not intrusive and it's pretty self-explanatory, I think.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: eri0o on 25 Sep 2021, 14:44
Another possibility for the sound indicator, trying to figure out which one works best.

a)
(https://user-images.githubusercontent.com/2244442/134773064-e190d11a-9feb-416b-90ab-ada88704307f.gif)

b)
(https://user-images.githubusercontent.com/2244442/134771622-17053bca-c426-46bb-b7e0-c6a65f8c6e24.gif)

c)
(https://user-images.githubusercontent.com/2244442/134772517-dfd75c97-bdc9-46ea-84e6-b644109a0fad.gif)
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Laura Hunt on 25 Sep 2021, 20:03
I think the audio indicator should go outside of the sprite box. In these three cases the icon is clearly visible because the sprite has a large transparent area, but if the sprite is not transparent, the icon will be much harder to see (if not completely invisible, depending on the sprite colours). I think the very first example you posted is the right way to go here.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: eri0o on 25 Sep 2021, 20:38
Next iteration of the previous idea of use the Frame. The icon green square is actually the reverse color of whatever color is below, and the icon itself is draw with only white and green.

I think being inside the frame translates better the sound linked to the frame idea, so wanted to do an additional test. :)

(https://user-images.githubusercontent.com/2244442/134784755-570711cc-7104-4d62-bf37-c272482ec73c.png)
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Cassiebsg on 25 Sep 2021, 22:19
I think also it should stay outside the sprite, as it risks covering an important part of the sprite.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Laura Hunt on 29 Sep 2021, 20:22
Sorry for not having dropped by in a while :) This latest revision does look much better, but I think I have to agree with Cassie. It might be a bit of an edge case but I'm not sure having anything on top of the sprite is a good idea...
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Alan v.Drake on 30 Sep 2021, 01:30
I'd rather the icon be inside. Nobody has ever managed too see jack squat in those ant-sized frames anyway.
Besides, eri0o implemented a magnifying slider and i can make a smaller icon made only of inverted color, so there's no actual obstruction. The complaints are invalid.

Moreover, I wonder if anyone would actually notice, since linking audio to frames doesn't happen very often.

- Alan
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: RickJ on 06 Oct 2021, 04:57
I believe having the icon in frame would be a problem in the example Dave Gilbert provided in the thread talking about the magnifying slider.  He has a whole view of the character lying or rolling on the ground rather than standing at the farleft.  In frame would be acceptable if one could drag it around to an ubobstructive location.   
https://www.adventuregamestudio.co.uk/forums/index.php?topic=59418.msg636639980#msg636639980 (https://www.adventuregamestudio.co.uk/forums/index.php?topic=59418.msg636639980#msg636639980)
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: eri0o on 14 Jan 2022, 12:21
(https://user-images.githubusercontent.com/2244442/149632626-a1d974e4-18be-4492-bfc0-95c1cad2aad3.png).

I removed the DLY as indicator of delay, and now if the delay is non zero, I added an icon for it with it's value. A sound in the frame is also indicated below. Hopefully this is good enough so we can go this way.

Edit: it will be in the next release of 3.6.0
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Laura Hunt on 18 Jan 2022, 17:33
Well, I don't know what others will think, but this looks good to me! Very elegant and not intrusive at all.
Title: Re: [Feature suggestion] Frame-linked audio visual indicator & Audioclip volume
Post by: Crimson Wizard on 18 Jan 2022, 18:07
Personally I feel like these icons should be locked to certain position, like they often do on status bars.

Example: the clock icon at the left, and sound icon aligned at the right, so that it would always be on same relative spot.

But I guess one needs to work with the editor for a while to see how it is.

NOTE: the icons are included in the latest release of 3.6.0 alpha
(https://www.adventuregamestudio.co.uk/forums/index.php?topic=58976.0)