AGSEditor: New features (Source code now available)

Started by tzachs, Sun 31/10/2010 23:48:35

Previous topic - Next topic

tzachs

Like Calin, I have a beta ready to test some new features I added.
The features are desperate to be tested, the more feedback the better!

THIS IS BETA. TEST ONLY ON A BACKUP OF YOUR GAME!!!

Features Added:

- Loop editing capabilities in View Editor.
 You can now: copy loop, cut loop, paste loop, paste loop flipped, flip all frames in loop and
 quick import loop from folder (the first sprite you select in the folder will be the first sprite
 in the loop, followed by the rest until the end of the folder).
 To access these capabilities, right click next to the loop you want to edit.

- Enhanced Find/Replace
 * Added an option to choose between find/replace in current document, or in current
    project (until now it was always current document).
 * Added a Find All (Ctrl+Shift+F or from the menu) & Replace All (Ctrl+Shift+E or from the
    menu). The "Find All" will open a list box with all of the findings, double clicking an item
    in the list will navigate you to the appropritate line.
 * Added Auto-Complete to the combo boxes for Find/Replace that completes from the
    previous searches.
 * Find/Replace will also work in dialogs now.
 * Find window will not take focus. So that you can find a certain keyword, off click from  
    the Find window, edit the line in the script editor and continue with the Find window.


- Find All Usages (pretty basic for now though)
 Right click on a member in the script, and select "Find All Usages" to get a list of all
 usages of this member. Double clicking an item in the list will navigate you to the
 appropriate line.

- Fixed this bug.

Known Issues:

This should be fixed in the new release.
- Find All Usages on a member which was defined in the scope of a single file, will find
 usages of members with the same name on different files as well.


- Find All Usages on a member of a struct will find usages of members with the same name
 of different structs as well.

- Since the Auto Complete for ComboBox in dot net is apparently not case sensitive and
 can't be configured to be (WTF?), this causes the following problem:
 If you enter a new name to find/replace (for example "string"), you won't be able to enter
 the same name but with a different capitalization (for example "String"), it will be
 considered as the first one. Now, I don't see anyway to fix that besides implementing a
 new combo box which I don't want to do, so tell me if you find this bug critical (or know
 how to fix it). I can roll back the auto complete feature if you think this is a critical bug.

Download

EDIT BY CJ: removed download links, get 3.2.1 beta 1 instead which integrates these changes

monkey0506

w00t for Find/Replace in entire project.

Matti

Quote from: monkey_05_06 on Sun 31/10/2010 23:58:43
w00t for Find/Replace in entire project.

Seconded! The loop stuff is pretty cool too. No time to check it out right now though..

Knox

--All that is necessary for evil to triumph is for good men to do nothing.

Dualnames

"- Loop editing capabilities in View Editor.
  You can now: copy loop, cut loop, paste loop, paste loop flipped, flip all frames in loop and
  quick import loop from folder (the first sprite you select in the folder will be the first sprite
  in the loop, followed by the rest until the end of the folder).
  To access these capabilities, right click next to the loop you want to edit."

This beats any addition ever made for AGS in the future to come (including porn, pink, kim kardashian)!!!

The Find/Replace beats the above addition.
Tzachs you flight of the concord you!! :D
Worked on Strangeland, Primordia, Hob's Barrow, The Cat Lady, Mage's Initiation, Until I Have You, Downfall, Hunie Pop, and every game in the Wadjet Eye Games catalogue (porting)

Calin Leafshade

Dual, I'm pretty sure you were saying in IRC that "AGS doesnt need to be changed" and "It's not AGS if CJ didnt do it"

Make up your damn mind.

Dualnames

Quote from: Calin Leafshade on Mon 01/11/2010 14:12:24
Dual, I'm pretty sure you were saying in IRC that "AGS doesnt need to be changed" and "It's not AGS if CJ didnt do it"

Make up your damn mind.

I just never needed to move my gui controls with the keyboard that's all. But I've been using find and search long-time, and it's been a pain at times.
The real reason is I'm too goddamn cool to make up my mind. Or just retarded.
Worked on Strangeland, Primordia, Hob's Barrow, The Cat Lady, Mage's Initiation, Until I Have You, Downfall, Hunie Pop, and every game in the Wadjet Eye Games catalogue (porting)

Ryan Timothy B

I haven't downloaded this, but if you're working on the Find/Replace, it would be nice if the window didn't take focus. So that you can find a certain keyword, off click from the Find window, edit the line in the script editor and continue with the Find window.

It would be super cool if the window would be at half transparency or something when you're off clicked from it.

cianty

I don't have the time to test it now but those features are AWESOME and I hope to take advantage of them in the future. Very very useful!
ca. 70% completed

tzachs

Thank you all (better than porn, really?)  :)

Quote from: Ryan Timothy on Mon 01/11/2010 17:16:02
I haven't downloaded this, but if you're working on the Find/Replace, it would be nice if the window didn't take focus. So that you can find a certain keyword, off click from the Find window, edit the line in the script editor and continue with the Find window.

It would be super cool if the window would be at half transparency or something when you're off clicked from it.

That's a nice suggestion, I'll see if I can implement it.

Lt. Smash

Quote from: tzachs on Mon 01/11/2010 18:47:49
Quote from: Ryan Timothy on Mon 01/11/2010 17:16:02
I haven't downloaded this, but if you're working on the Find/Replace, it would be nice if the window didn't take focus. So that you can find a certain keyword, off click from the Find window, edit the line in the script editor and continue with the Find window.

It would be super cool if the window would be at half transparency or something when you're off clicked from it.

That's a nice suggestion, I'll see if I can implement it.
Or (better), like the find window in Firefox, that actually isn't a window, but integrated into the GUI ;)

Shane 'ProgZmax' Stevens

tzachs- does the find-replace stuff work in dialog scripts now?  If not, it would be nice to introduce this functionality to dialogs since they have pretty much the same functionality of other scripts.

tzachs

No, I didn't implement it for the dialogs (and in fact, I didn't know it didn't work on them already).
I'll see if I can include the dialogs as well, thanks for the tip.

tzachs

Bump!
New version is available, and the source code is now available too, the links are in the first post.

New additions:
- Fixed Ryan Timothy's reported bug
Ryan, if you can test that the fix works, I will be grateful.

- Implemented Ryan Timothy's suggestion, so that the find window will not take the focus. (Sorry Lt. Smash, I felt it was more easy and appropriate to keep the find as a seperate window).

- Implemented ProgZMax suggestion, about supporting Find/Replace in Dialogs too.

- Fixed the following issue in Find All Usages:
Find All Usages on a member which was defined in the scope of a single file, will find
usages of members with the same name on different files as well.


Ryan Timothy B

#14
Excellent stuff. I really like the search window. Only thing I felt may be a little odd was that when there isn't anything by the string you're searching for, once you click ok on the popup, it closes the search. Not a big issue.

As for the annoying popup thing, it's pretty much fixed. The only issue is when you hover the mouse over the drop-down thing at the top. The one that allows you to quickly move to different functions in the script. Once you hover over that, the popup will show up and stay visible.

But it's not often that someone will hold their mouse above the drop-down without actually using the drop-down.


Also I'm not sure if this is relevant to what you've done, or perhaps AGS has always said this and I've never read it. At the bottom it says:
AutoComplete error: Invoke or BeginInvoke cannot be called on a control until the window handle has been created.

No idea what it means. :P It doesn't say it anymore now that I've closed it and reopened it. Odd. Not sure what I would have done to have that show up.

tzachs

Thank you Ryan, I uploaded a new version with fixes.

Quote from: Ryan Timothy on Sat 18/12/2010 23:56:14
Excellent stuff. I really like the search window. Only thing I felt may be a little odd was that when there isn't anything by the string you're searching for, once you click ok on the popup, it closes the search. Not a big issue.
Fixed!

Quote
As for the annoying popup thing, it's pretty much fixed. The only issue is when you hover the mouse over the drop-down thing at the top. The one that allows you to quickly move to different functions in the script. Once you hover over that, the popup will show up and stay visible.

But it's not often that someone will hold their mouse above the drop-down without actually using the drop-down.
Fixed!

Quote
Also I'm not sure if this is relevant to what you've done, or perhaps AGS has always said this and I've never read it. At the bottom it says:
AutoComplete error: Invoke or BeginInvoke cannot be called on a control until the window handle has been created.

No idea what it means. :P It doesn't say it anymore now that I've closed it and reopened it. Odd. Not sure what I would have done to have that show up.
I'm not sure if it's related to something I did or not.
I added a dump in case that happens again.
So, if you encounter this again (with this version), you should hopefully find a file in the AGS folder named "AutoComplete Dump.txt", and if you'll send me the file I'll see if I can figure it out.

subspark

Any chance someone out there can fix these?



Cheers,
Sparky.

Shane 'ProgZmax' Stevens

I don't actually encounter those alignment problems myself, subspark.  Are you using really large windows fonts or something?

tzachs

subspark, it seems that you don't have the latest version (basing that on the fact that you don't have a "Find" button in the color finder window), and that possibly some of these problems are already fixed.

I went through all of the problems you indicated, and like ProgZMax, I don't encounter most of them.
I still see the problem with the Lip Synch and the Color number label, but that's it.
In the dialog window I have a scrollbar so I can access the buttons, and all the rest look fine on my monitor.
Oh, and I didn't find the "Hotspot marker" window anywhere, maybe that's obsolete...

Shane 'ProgZmax' Stevens

Yeah, if it's one of the older versions of the editor CJ had reported problems with the window panes and such but fixed it in the next version.  This may be one of the 3.0 releases?

SMF spam blocked by CleanTalk