Author Topic: Bug reports & suggestions  (Read 66742 times)

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #60 on: 30 Mar 2013, 11:22 »
the dropdown menu next to the quicksearch on every page has no effect. It always searches the entire forum and not for example the board you are in atm.

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #61 on: 30 Mar 2013, 12:05 »
and a minor bug, but probably easier to fix: The from the forums box on the AGS startpage shows the name of the poster as the signup name, not the display name.

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #62 on: 30 Mar 2013, 12:28 »
and while I'm on it...

the awards page is a cool thing but the link named
Full games page entry
on commercial games without further notice of the game beeing commercial on the awards page will probably evoke feelings of 'I'm so gonna download this now' and then the disappointment of seeing only a demo available for free. So what I'm trying to say here is, that commercial games that only have a demo available in the database should be noted as that on the awards page to avoid frustrated visitors.

And naturally I'm interested in what awards the game has won right on the awards page. Also nominations of course. When displaying the cup rating and the description from the database, displaying the award won and nominated for should be easy to do on the awards page. Right in between the desription and the cupratings seems like a nice place for this.


and actually using *ZOMG* a table for the Award Nominees underneath the winners on the page wouldn't be so bad, as it is tabular data indeed and so the linebreaks would be indented. The current linebreaks look strange. A smaller font could also work as a temporarily fix until longer gametitles come along.

Re: Bug reports
« Reply #63 on: 30 Mar 2013, 19:03 »
Game search has some bugs. Not sure, but might be related to certain characters in game's name, such as whitespace or non-letters.
In particular, I was unable to find "Trilby's Notes" by typing in full game's name, but it worked when I typed in "Notes".

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #64 on: 31 Mar 2013, 00:10 »
It's probably because characters are escaped in the database, but the search strings aren't.  I'll fix it... eventually!

Peder 🚀

  • Been nearly 10 years, think it's time for a change
    • Lifetime Achievement Award Winner
Re: Bug reports
« Reply #65 on: 01 Apr 2013, 07:07 »
the dropdown menu next to the quicksearch on every page has no effect. It always searches the entire forum and not for example the board you are in atm.

This is not correct, all but the "this board" works, and reason that one doesn't work is a fault in the code:
Code: Adventure Game Studio
  1. <select name="search_selection">
  2.     <option value="entireforum" selected="selected">Entire Forum </option>
  3.     <option value="thisbrd">This board </option> <== value should be "thisboard" not "thisbrd"
  4.     <option value="thistopic">This topic </option>
  5.     <option value="members">Members </option>
  6.     <option value="entiresite">Entire Site </option>
  7. </select>

and a minor bug, but probably easier to fix: The from the forums box on the AGS startpage shows the name of the poster as the signup name, not the display name.
This is because it collects the name of the poster from the post part of the db and not from the user part.
It would be easy to change though.

Re: Bug reports
« Reply #66 on: 03 Apr 2013, 15:46 »
Someone broke teh game search:
Quote
Parse error: syntax error, unexpected T_ELSE in /var/www/ags/index.php on line 3288

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #67 on: 03 Apr 2013, 21:47 »
Someone broke teh game search:
Quote
Parse error: syntax error, unexpected T_ELSE in /var/www/ags/index.php on line 3288

Fixed?  Gimme some info, man!  Search terms at least.  The line number will probably have changed, since I added a load of completely unrelated code earlier.

I'll fix the search terms thing you mentioned before when I get the chance, but I need to make the data uniform, which is more of a job than you might think.


Re: Bug reports
« Reply #68 on: 03 Apr 2013, 22:03 »
Yes it is fixed, I was looking for "Cat Lady" and then "Lady".

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #69 on: 04 Apr 2013, 14:58 »
and actually using *ZOMG* a table for the Award Nominees underneath the winners on the page wouldn't be so bad, as it is tabular data indeed and so the linebreaks would be indented. The current linebreaks look strange. A smaller font could also work as a temporarily fix until longer gametitles come along.

Cool, thanks for adding all this in, another suggestion for the expandable table when clicking on the Award Nominees' more info link:


Code: Text
  1. <tr>
  2.   <td id="nominationsList####" class="awardNominee" style="display block">
  3.     nominations list
  4.   </td>
  5. </tr>
get rid of the style="display block" and replace it with colspan="3". Looks better!



and something minor again:
when clicking on

Award Wins >>
or
Award Nominations >>

and thus expanding the additional info the >> should logically become a
Award Wins <<
Award Nominations <<

then. To indicate that you collapse it by clicking again ;)

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #70 on: 04 Apr 2013, 19:28 »
I got distracted halfway through (by going to bed!) and didn't finish this yesterday, and have been busy all day today.  I'll take another look when I get the chance.

cat

  • Mittens Baronet
  • Rhonda Reindeer
    • cat worked on a game that won an AGS Award!
    •  
    • cat worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #71 on: 05 Apr 2013, 15:10 »
Suddenly the "See the people who made this game and any other games they've worked on >>>" dropdown doesn't seem to work anymore

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #72 on: 05 Apr 2013, 16:26 »
get rid of the style="display block" and replace it with colspan="3". Looks better!

The display:none is required for the hiding and showing of the nominees div.  Regardless, I had to rejig the way it's laid out, for reasons too boring to go into.  I also made the arrows swap directions.  It all looks pretty smart now, thanks for the suggestions!

Suddenly the "See the people who made this game and any other games they've worked on >>>" dropdown doesn't seem to work anymore

This was caused by an unforeseen consequence of selmiak's suggestions.  Should be fixed now though.

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #73 on: 05 Apr 2013, 18:34 »
on the mainpage the link to the News Archive >> doesn't have the >> included in the link while everything else has it in. Damn you OCD!!! :D

also there seems to be a 1 or 2 pixel high line on the very top of the mainpage that makes the scrollbar appear even though it is not needed. Then again this keeps the main page aligned and indented like on all the other pages. Still strange though.
« Last Edit: 05 Apr 2013, 18:38 by selmiak »

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #74 on: 05 Apr 2013, 19:23 »
on the mainpage the link to the News Archive >> doesn't have the >> included in the link while everything else has it in. Damn you OCD!!! :D

Fixed.  Although CJ seems to use >> to mean random things.  Some random links have it, when it generally means 'expand in page'.  I'll go through at some point and make it uniform.

also there seems to be a 1 or 2 pixel high line on the very top of the mainpage that makes the scrollbar appear even though it is not needed. Then again this keeps the main page aligned and indented like on all the other pages. Still strange though.

If you can work out where that's coming from, I'll fix it.  I had a fiddle, but I can't work it out.  The main problem with inheriting a design someone else created!

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #75 on: 05 Apr 2013, 20:54 »
If you can work out where that's coming from, I'll fix it.  I had a fiddle, but I can't work it out.  The main problem with inheriting a design someone else created!

What the... firebug doesn't work on the AGS page. What kind of sorcery is this?

but the
Code: CSS
  1. .fullWidthMainWrapper {
  2.     border-top: 1px solid #90AFF4;

would be my first guess, second guess the sticky footer, third guess this all combined and some more css... but without firebug (or fiddeling around with the css of a live page) this is just a very rough guess.

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #76 on: 05 Apr 2013, 21:13 »
Web Developer works here, if that helps.  It's good too.  .fullWidthMainWrapper did it though.

Peder 🚀

  • Been nearly 10 years, think it's time for a change
    • Lifetime Achievement Award Winner
Re: Bug reports
« Reply #77 on: 05 Apr 2013, 21:28 »
That is indeed the issue selmiak. Btw AGA, it seems most of the CSS classes are defined twice in the CSS file..
Only difference is how the colours are defined..

selmiak

  • ǝsıɔɹǝxǝ ʞɔǝu puɐ uıɐɹq
    • I can help with play testing
    • I can help with proof reading
    • I can help with translating
    • I can help with web design
    • selmiak worked on a game that won an AGS Award!
    •  
    • selmiak worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #78 on: 05 Apr 2013, 21:29 »
haha, BINGO!

will give webdeveloper a try on the next restart of firefox ;)

AGA

  • Adventure Game Aficionado
  • Administrator
  • ¡Qué alí­vio!
    • Lifetime Achievement Award Winner
    • AGA worked on a game that was nominated for an AGS Award!
Re: Bug reports
« Reply #79 on: 05 Apr 2013, 21:31 »
Okay, so apparently the border was somehow keeping the top menu bar fixed in the same place.  When it's removed, the menu bar items float around by a few pixels depending on how wide the page is.  Which looks really silly!  Any ideas?  CSS is such a pain, with everything being positioned relative to something else.