AGS 3.3.0 Release Candidate

[Snarky]

With the link you gave me here I just see the forums.

That, at least, has a simple explanation. The ? at the end of the sentence gets included in the URL.

[cat]

Yes, it works now! Thanks AGA, now I don't have to bother Crimson with PMs anymore

[AGA]

Still work?  I hid the 'cat' membergroup, hopefully that didn't make a difference?

[cat]

Yes, still working 

[DoorKnobHandle]

BUG REPORT: Clicking "Find usage" on the automatically generated VIEW1 says "No usage found" but when I try and delete it, it (rightfully) complains about being the normal view for the, also automatically generated, EGO character.

BUG REPORT: Importing a sprite, creating a room object, clicking the "..." in the image property, picking the imported sprite doesn't actually change the image property. It leaves it at the default value (0) and hides the object properties in a rather weird fashion.

[Joseph DiPerla]

Another BUG: Whenever I edit a script file and then save the game or run it, the editor tells me that the script was modified by an outside editor. When I click ok to reload, it crashes the Editor.

[DoorKnobHandle]

FWIW, that does not happen on my end, Joseph!

[Crimson Wizard]

Another BUG: Whenever I edit a script file and then save the game or run it, the editor tells me that the script was modified by an outside editor. When I click ok to reload, it crashes the Editor.

Is there any error message? If there is, please post the contents.

[Joseph DiPerla]

The first message that appears when I edit a script file and then save it:

The File SCRIPTNAME.asc has been modified externally. Do you want to reload it?

When I hit yes, it would just crash, no error message. The funny thing is, Last night I was able to reproduce it every time, even after restarting my pc. For some reason, now, it wont crash. However, it still brings up the message above, which is still pretty annoying for every time I save a script. I do not know if this makes a difference, but the game I am working on was built with AGS 2.62 first, then I brought it into 2.72 and then 3.0 and finally 3.30. I figured I would mention that, but I don't think it really makes a difference that it does that because I started a new game and tried to edit the text file and it did the same thing.

[DBoyWheeler]

Meh, I think I'll wait till the final cleaned-up release before downloading it.

[tzachs]

BUG REPORT: Clicking "Find usage" on the automatically generated VIEW1 says "No usage found" but when I try and delete it, it (rightfully) complains about being the normal view for the, also automatically generated, EGO character.

Currently "Find all usages" find the usages in the scripts (including dialogs).
I'll think of how to add other types of existing links for future releases.

BUG REPORT: Importing a sprite, creating a room object, clicking the "..." in the image property, picking the imported sprite doesn't actually change the image property. It leaves it at the default value (0) and hides the object properties in a rather weird fashion.

That's my bad, issue is now fixed in git.

Another BUG: Whenever I edit a script file and then save the game or run it, the editor tells me that the script was modified by an outside editor. When I click ok to reload, it crashes the Editor.

My only theory is this (of why the message was shown):
When the editor gets an event from the OS that a file was changed, it doesn't know if it is changed externally or from within the application.
So it does the distinction by marking each script with the last time that it started an internal save, and then when it gets the event it checks if two seconds have elapsed from the last save time.
So, if for some reason saving the script from the editor takes you more than two seconds it would think it was changed externally even though it wasn't.
Maybe you have a very big script file? Or work with a very slow hard drive?

[Crimson Wizard]

When the editor gets an event from the OS that a file was changed, it doesn't know if it is changed externally or from within the application.
So it does the distinction by marking each script with the last time that it started an internal save, and then when it gets the event it checks if two seconds have elapsed from the last save time.

Why not mark the end of writing?

[tzachs]

Yes, but first I want Joseph to confirm that this is really the issue, I don't want to fix something if it's not broken (maybe CJ had a reason to program it like that, I don't want to needlessly break something).

[Joseph DiPerla]

tzachs, I sent you a pm with a link. That link will reproduce it once you turn it into a new project. It did on mine. Hope that helps a bit. But as I said, it happens even with a brand new project from scratch. Maybe its just my system? I could try and reproduce a video for you if you would like.

[tzachs]

It didn't reproduce to me, so I guess it's related to your computer.
As CW suggested I changed the mark time of the save to be just before releasing the file.
I commited this change to git.
Please use it and see if it solved the issue for you.

In other news, I'm going away on a three weeks vacation (New Zealand, yay!), so I won't be able to help out with bugs in the near future..

[Joseph DiPerla]

Hey tzachs. I compiled the new Git upload. Still giving me that issue. It most likely is an issue on my system then. Oh well. Thanks for Trying.

[Crimson Wizard]

Hey tzachs. I compiled the new Git upload. Still giving me that issue. It most likely is an issue on my system then.

Does this happen if you use 3.2.1?
I believe we should eventually find the root of this problem, even if it happens only on some systems.

[Joseph DiPerla]

Hey tzachs. I compiled the new Git upload. Still giving me that issue. It most likely is an issue on my system then.

Does this happen if you use 3.2.1?
I believe we should eventually find the root of this problem, even if it happens only on some systems.

Yes, it does. Sorry.

[Khris]

Some small bugs regarding the script editor:
1) Occasionally, the editor will be much smaller than the available window space.

2) I switch tabs a lot using Ctrl-Tab. Pressing it twice will basically update the auto-complete list, and I use this all the time. Now, only every other Ctrl-Tab seems to register. And whenever it fails, it looks like a tab in the background still has focus because pasting something doesn't end up in the open editor tab but in one in the background. Clicking in the open editor fixes this, of course.

[Crimson Wizard]

I was able to reproduce same (or similar) error as DiPerla reported.
This happens almost every time, but on certain machine. I am not yet sure what difference causes this, but I have access to this machine almost every day, so chances are I may find out more; plus I run it under debugger.

OS is Windows 7 Ultimate N SP1.

First time I open the script, change something and save normally. The next time I make any change to that script and try to save, the message box appears, telling that script was modified outside the editor, asking me if I want to update it. When I hit "Yes", error occurs:

A first chance exception of type 'System.InvalidOperationException' occurred in System.Windows.Forms.dll

Additional information: Cross-thread operation not valid: Control 'scintillaControl1' accessed from a thread other than the thread it was created on.

Stack trace:

   System.Windows.Forms.dll!System.Windows.Forms.Control.Handle.get() + 0xc4 bytes   
>   AGS.Controls.dll!Scintilla.ScintillaControl.SendMessageDirect(uint msg = 2140, System.IntPtr wParam = 0, System.IntPtr lParam = 0) Line 684 + 0xe bytes   C#
   AGS.Controls.dll!Scintilla.ScintillaControl.SendMessageDirect(uint msg = 2140) Line 711 + 0xf bytes   C#
   AGS.Controls.dll!Scintilla.ScintillaControl.IsReadOnly.get() Line 625 + 0xd bytes   C#
   AGSEditor.exe!AGS.Editor.ScintillaWrapper.SetText(string newText, bool clearModified = true) Line 451 + 0x11 bytes   C#
   AGSEditor.exe!AGS.Editor.ScintillaWrapper.SetText(string newText) Line 441 + 0xd bytes   C#
   AGSEditor.exe!AGS.Editor.ScriptEditor.PromptUserThatFileHasChangedExternally() Line 206 + 0x2c bytes   C#
   AGSEditor.exe!AGS.Editor.ScriptEditor.Events_FileChangedInGameFolder(string fileName = "guiscript.asc") Line 230 + 0x8 bytes   C#
   AGSEditor.exe!AGS.Editor.EditorEvents.OnFileChangedInGameFolder(string fileName = "guiscript.asc") Line 108 + 0x11 bytes   C#
   AGSEditor.exe!AGS.Editor.AGSEditor._fileWatcher_Changed(object sender = {System.IO.FileSystemWatcher}, System.IO.FileSystemEventArgs e = {System.IO.FileSystemEventArgs}) Line 728 + 0x22 bytes   C#
   System.dll!System.IO.FileSystemWatcher.OnChanged(System.IO.FileSystemEventArgs e) + 0x84 bytes   
   System.dll!System.IO.FileSystemWatcher.NotifyFileSystemEventArgs(int action, string name) + 0xa1 bytes   
   System.dll!System.IO.FileSystemWatcher.CompletionStatusChanged(uint errorCode, uint numBytes, System.Threading.NativeOverlapped* overlappedPointer = 0x02a2d650) + 0x39d bytes   
   mscorlib.dll!System.Threading._IOCompletionCallback.PerformIOCompletionCallback(uint errorCode, uint numBytes, System.Threading.NativeOverlapped* pOVERLAP) + 0x54 bytes   
   kernel32.dll!@BaseThreadInitThunk@12()  + 0x12 bytes   
   ntdll.dll!___RtlUserThreadStart@8()  + 0x27 bytes   
   ntdll.dll!__RtlUserThreadStart@8()  + 0x1b bytes   

The line is:

Code: C#

m.HWnd = Handle;

UPD: I sort of found out why it causes this "different thread" error.
It looks like the "Script was changed" message box is actually created on different thread! I may simply ignore that message, click back on editor and continue to edit script, and every time I save more message boxes will pop up.

So, what we have here is two separate issues:
1. The message box on other thread (or non-modal).
2. The faulty changes detection.