Jibble

Author Topic: afxres.h  (Read 1224 times)

afxres.h
« on: 02 Sep 2014, 21:34 »
I've been trying to get the AGS Engine building on Windows using free tools. I've had pretty good success with the Windows 7 SDK: http://www.microsoft.com/en-us/download/details.aspx?id=18950 (command line VC9 compiler and toolchain for free, minus the Visual Studio GUI). I only had one hurdle- an include in Engine\resource\version.rc , afxres.h . The problem is that the Windows SDK doesn't come with MFC. Following advice from S|O I've replaced the include with the following:

Code: [Select]
#include "WinResrc.h"
#define IDC_STATIC  -1

And success, I now have the engine compiling successfully! Would the rest of you be up for making this a permanent change? It seems worthwhile, if it makes the Engine buildable with free tools- makes it that little bit easier to get new developers for Windows. Especially since VS2008 isn't really available for sale any more.

PS I'm not entirely certain if this is the best venue to ask this sort of question- I've not contributed to an Open Source project before... should I just be sending in Git pull requests?

monkey0506

  • SEND PIZZA.
    • Best Innovation Award Winner 2017, for his work to help AGS games reach the widest possible audience - through popular distribution platforms (Steam, Galaxy) as well as other operating systems (Android, Linux)
    • monkey0506 worked on one or more games that won an AGS Award!
    •  
    • monkey0506 worked on one or more games that was nominated for an AGS Award!
Re: afxres.h
« Reply #1 on: 02 Sep 2014, 23:19 »
Visual Studio 2008 Express (e.g., the "free" edition of VS) has always been able to build the engine, but if this crops out unnecessary header info then I don't see why not.

As far as contributing to the project, the way it usually works is that you create a fork of the official git repo and then submit a pull request. This is actually pretty simple using a Github account (which is also free), or you can always upload your fork elsewhere (my fork is cloned on Github.com and Bitbucket.org).

Wyz

  • anno 1986
    • I can help with making music
    • I can help with story design
    • I can help with translating
    • I can help with voice acting
    • I can help with web design
    • Wyz worked on one or more games that won an AGS Award!
    •  
    • Wyz worked on one or more games that was nominated for an AGS Award!
Re: afxres.h
« Reply #2 on: 05 Sep 2014, 10:47 »
If AGS is not using MFC (and as far as I know it isn't) there is no reason to include that header so it would be safe to remove it. MSVS likes to add the header by default for some reason; oh well. :P
Life is like an adventure without the pixel hunts.

Re: afxres.h
« Reply #3 on: 08 Sep 2014, 20:31 »
Thanks for pointing out. IIRC this was already mentioned once when we started to work on the open-sourced code engine, but we forgot to make a correction.
Fixed with commit 0acc682