Server migration + site 'upgrade'

Started by AGA, Sun 30/12/2018 23:02:50

Previous topic - Next topic

AGA

Hello!

We have just migrated the site and forums to a new and shiny server, and I have completely rewritten the AGS site.  You shouldn't notice many differences, but some of the changes include:

  • fixed site search!
  • improved stability of forums and site!
  • SSL! (ish - read below)
  • a few small improvements and changes to the games pages

You may very well notice some glitches here and there, and I have forgotten to address issues people mentioned in the past.  Anything you do notice from now on, please let me know!

I have made the first steps to getting the site fully SSL enabled.  However, until everyone updates their forum profiles, posts and signatures to use only HTTPS links (so no HTTP ever again!) we cannot be fully compliant.

Slasher

Hi

why do some games from profile show;  test.file path and show 404?

Slasher

Traveler

The wiki doesn't seem to work - when I click the AGS Wiki link, I get a 404. The behavior is the same when I try to visit a particular Wiki page through a Google link.

dactylopus

Profile Images / Avatars don't seem to be working for everyone.

Traveler

Also, the main AGS site seems to be much wider than it used to be - I usually don't use the browser in full-scrreen mode and I didn't have to horizontally scroll in the past but now the page is about ~200 pixels wider than before.

cat

#5
Images from http sites don't load anymore. I'll try to set up https with my hosting provider, but need to pay for that separately and I need some time for it.
In the meantime, I linked the screenshot from the database entry in the most recent completed games and MAGS thread. At least game download still works.

And regarding what Traveler said: On my phone, it even looked like the right menu bar disappeared (but I actually just had to scroll there). So yeah, seems wider.

Edit: My provider updated the packages and included free let's encrypt support. What is better: wildcard or no-wildcard certificate?

Snarky

Quote from: dactylopus on Mon 31/12/2018 07:23:18
Profile Images / Avatars don't seem to be working for everyone.

They need to be on an https URL.

eri0o

#7
@cat : what does it mean wildcard or no-wildcard certificate? Does your website uses subdomains? From reading on, it appears they are required with subdomains - like www. and others... The host I use just have a button that magically turns https from let's encrypt on, so I never thought about that. You can also look into .htaccess rules to force http to https redirect (one that I use is RewriteRule ^.*$ https://%{SERVER_NAME}%{REQUEST_URI} [R=301,L] )

Edit: found a cool thing here -> github.com/phanan/htaccess

AnasAbdin

Quote from: AGA on Sun 30/12/2018 23:02:50
We have just migrated the site and forums to a new and shiny server, and I have completely rewritten the AGS site.

Thank you for the great effort and the time spent <3 <3 <3

AGA

Quote from: Slasher on Mon 31/12/2018 03:26:00
Hi

why do some games from profile show;  test.file path and show 404?

Slasher

Fixed!

Quote from: Traveler on Mon 31/12/2018 06:43:38
The wiki doesn't seem to work - when I click the AGS Wiki link, I get a 404. The behavior is the same when I try to visit a particular Wiki page through a Google link.

Fixed!

Quote from: dactylopus on Mon 31/12/2018 07:23:18
Profile Images / Avatars don't seem to be working for everyone.

Expected! (as in the first post).  You can't have a HTTPS site that links to non HTTPS addresses, so I've turned on the forum's image proxy, which will effectively ban any images that aren't coming from an HTTPS address.  It shouldn't be a huge problem, as most modern hosting sites offer HTTPS for free.

dactylopus

Quote from: Snarky on Mon 31/12/2018 09:54:42
Quote from: dactylopus on Mon 31/12/2018 07:23:18
Profile Images / Avatars don't seem to be working for everyone.
They need to be on an https URL.
No more tinypic, I suppose.

Perhaps this tidbit in the Modify Profile page should be updated:

"Specify your own avatar by URL
(e.g. http://www.mypage.com/mypic.gif)"

Slasher

The Graphics on game page show:  HD, 8-bit (256 col)

If I change to 32 bit I get: Database query G.37.11 error: Column 'mirror_url' cannot be null


AGA

Quote from: dactylopus on Mon 31/12/2018 13:11:40
Perhaps this tidbit in the Modify Profile page should be updated:

"Specify your own avatar by URL
(e.g. http://www.mypage.com/mypic.gif)"

Changed to: "Specify your own avatar by URL (e.g. https://www.mypage.com/mypic.gif - this must start with https, or it won't work!)"

Quote from: Slasher on Mon 31/12/2018 13:38:38
The Graphics on game page show:  HD, 8-bit (256 col)

If I change to 32 bit I get: Database query G.37.11 error: Column 'mirror_url' cannot be null



Should be fixed!

cat

#13
Thanks AGA for your efforts!

I managed to turn on https for my webspace. But I had to change the URL of my avatar manually to https.
Interestingly, other images (like here https://www.adventuregamestudio.co.uk/forums/index.php?topic=56539.msg636596982#msg636596982) seem to work.
Is it possible to update all avatar links automatically in the database?

Edit: Another issue: Picks of the months seems to be reset to July 2017

AGA

Quote from: Traveler on Mon 31/12/2018 07:26:54
Also, the main AGS site seems to be much wider than it used to be - I usually don't use the browser in full-scrreen mode and I didn't have to horizontally scroll in the past but now the page is about ~200 pixels wider than before.

Sorry, forgot to reply to this.  This was deliberate.  The old site looked tiny on modern monitors (even on 1024 x 768!), so I increased the main text area to be wider, while fitting in the same overall dimensions.  It may be a bit more awkward on mobile now, but honestly the site has always been far from optimised for mobile!  It'd take a full redesign before we ever had the site working properly on mobile.

cat

Continuing with issues:

The Member Map seems to link to the old one and terribly out of date. I'd remove it completely.
On the games page, some games don't have a screenshot in the overview, but when you open the page and click on one of three tiny preview screenshots, it is shown correctly. Happens for some of the pick of the month.

AGA

Quote from: cat on Mon 31/12/2018 14:02:26
Thanks AGA for your efforts!

I managed to turn on https for my webspace. But I had to change the URL of my avatar manually to https.
Interestingly, other images (like here https://www.adventuregamestudio.co.uk/forums/index.php?topic=56539.msg636596982#msg636596982) seem to work.
Is it possible to update all avatar links automatically in the database?

Edit: Another issue: Picks of the months seems to be reset to July 2017

It's not safe to find and replace everyone's avatar, since currently the forum software is blocking them because they aren't HTTPS.  If the URLs look like HTTPS but actually return 404 (because the HTTPS version doesn't actually exist), then we might end up with threads full of broken images...  Hopefully active users will notice and fix their avatars soon enough.  Most inactive users' avatars have already expired anyway, so no real difference!

As for the in thread images, this is how SMF's image proxy is supposed to work - it downloads the file locally, then hosts it itself if it isn's HTTPS.  It just seems it doesn't work for avatars for some reason.

AGA

Quote from: cat on Mon 31/12/2018 14:11:19
The Member Map seems to link to the old one and terribly out of date. I'd remove it completely.

The map linked to on the forums (https://www.adventuregamestudio.co.uk/forums/index.php?action=googlemap) is definitely up to date... How do you define "the old one"?  I think it may be the style changed slightly, but it's definitely using up to date information, and the latest Google Maps API.

Quote from: cat on Mon 31/12/2018 14:11:19
On the games page, some games don't have a screenshot in the overview, but when you open the page and click on one of three tiny preview screenshots, it is shown correctly. Happens for some of the pick of the month.

Oh yeah, I need to generate thumbnails for some of the games, forgot to do it earlier.

AGA

Quote from: cat on Mon 31/12/2018 14:02:26
Edit: Another issue: Picks of the months seems to be reset to July 2017

Fixed.  The dates recent entries used were in the wrong format, so needed to be converted in the database.

Traveler

AGA, thank you for modernizing the site and for the fixes.

I just noticed that the landing URL (http://www.adventuregamestudio.co.uk/) redirects to the Wiki now, not to the AGS landing page.

Tycho Magnetic Anomaly

Hi just first off all i would like to say thanks to ags for the many improvements and the time hes put in, not least since it was over the holiday season for him too. However I am thoroughly not happy at all with the issue of content from my server not being able to display on the forum anymore. I realize why, but I cannot afford to upgrade or change my server,  i simply am not in a position to change my server around since i have other sites on my hosting package.   I find this very disappointing not least since I have no issues whatsoever displaying my server content on other forums and social networking platforms that are far more modern then this forum platform.

I feel so strongly about this that I feel like leaving the forum now if its a case exceptions for people with known servers and are genuine people known to the forum cannot be made without people having to turn their servers upside down and pay money to accommodate the change on this one forum.

Just to be clear I understand the time and work gone into the improvements, and appreciate that, however this issue with blocking servers from known members is a step too far for me.

AGA

Quote from: Tycho Magnetic Anomaly on Mon 31/12/2018 15:57:32
Hi just first off all i would like to say thanks to ags for the many improvements and the time hes put in, not least since it was over the holiday season for him too. However I am thoroughly not happy at all with the issue of content from my server not being able to display on the forum anymore. I realize why, but I cannot afford to upgrade or change my server,  i simply am not in a position to change my server around since i have other sites on my hosting package.   I find this very disappointing not least since I have no issues whatsoever displaying my server content on other forums and social networking platforms that are far more modern then this forum platform.

I feel so strongly about this that I feel like leaving the forum now if its a case exceptions for people with known servers and are genuine people known to the forum cannot be made without people having to turn their servers upside down and pay money to accommodate the change on this one forum.

Just to be clear I understand the time and work gone into the improvements, and appreciate that, however this issue with blocking servers from known members is a step too far for me.

As discussed on Discord, I've turned the proxy off for the time being.  We really should be moving towards full HTTPS hosting as soon as possible though.

Cassiebsg

AGA, is it possible to turn all imgur pics into https? Since they already are. I changed my avatar and sig image on my own, but I won't go through the site, find all my posts and change the pics.
Think it would at least me safe to to this for imgur... maybe other pic sites are providing the same url for http and https? I only know imgur does it, so that is an easy "fix".

How ever the way it is know, most threads are broken, since it won't display non https images... Could one add automaticly something like a "spoiler" tag? Showing the link to a non-http image instead of just displaying nothing?
There are those who believe that life here began out there...

selmiak

as written on discord, my idea for a compromise to all the legacy image in the forum that survived would be to screw the proxy and somehow have the forum not accept insecure images from now on, maybe with a regex check on http: * [.jpg|.png|.bmp|.gif] but I suck at writing regex.



a minor thing is, the forum spoiler button no longer has the crossed eye image.

Cassiebsg

I always type my code... I think typing [ hide ] and a lot easier than [ spoiler ]  :P
There are those who believe that life here began out there...

Tycho Magnetic Anomaly

Hi again,  look I feel really bad now, and I don't think I was very fair jumping on this so quickly,  tbh I was already in a bit of a funny mood anyway and the forum change with respect the image posting just took me a bit off kilter there. On thinking about it more with a calmer head I realize that AGA has done everything right, its only inevitable that this would be done anyway, its progress, and no amount of inconvenience has the right to stand in the way of valid and important progress.

So on that note I am very sorry for taking such issue over this.  Ok sure there's a whole bunch of images I posted going back a year or more that are broken on page, but they can be fixed one by one, and from now on I will just make sure to post up on imgur,  so no damage done really.

Thanks again for the time and work put in aga and whoever is helping in the background, I guess there might not even be a forum without you folks.

Traveler

The wiki link is broken again - it returns 404.

TheFrighter


Uhm, the Search finds very little issue.

_

paolo

Looks nice, and the new server seems to be faster. Good work, guys.

I'm having trouble updating my game page: I get a load of warnings and errors when I click "Update" (see below). I suspect this is due to the migration as it wasn't happening before.


Warning: unlink(/home/ags/html//images/games/2313_1.png): Permission denied in /home/ags/html/pages/game.php on line 2372
Could not delete image 1: /home/ags/html//images/games/2313_1.png


Warning: move_uploaded_file(/home/ags/html//images/games/2313_1.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpyNvSSK' to '/home/ags/html//images/games/2313_1.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_1.png.
Warning: move_uploaded_file(/home/ags/html//images/games/2313_2.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpv2tgA6' to '/home/ags/html//images/games/2313_2.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_2.png.
Warning: move_uploaded_file(/home/ags/html//images/games/2313_3.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpL3eMTt' to '/home/ags/html//images/games/2313_3.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_3.png.Database query G.37.11 error: Column 'dl_url_agsa' cannot be null

AGA

Quote from: paolo on Tue 01/01/2019 12:59:19
Looks nice, and the new server seems to be faster. Good work, guys.

I'm having trouble updating my game page: I get a load of warnings and errors when I click "Update" (see below). I suspect this is due to the migration as it wasn't happening before.


Warning: unlink(/home/ags/html//images/games/2313_1.png): Permission denied in /home/ags/html/pages/game.php on line 2372
Could not delete image 1: /home/ags/html//images/games/2313_1.png


Warning: move_uploaded_file(/home/ags/html//images/games/2313_1.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpyNvSSK' to '/home/ags/html//images/games/2313_1.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_1.png.
Warning: move_uploaded_file(/home/ags/html//images/games/2313_2.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpv2tgA6' to '/home/ags/html//images/games/2313_2.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_2.png.
Warning: move_uploaded_file(/home/ags/html//images/games/2313_3.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpL3eMTt' to '/home/ags/html//images/games/2313_3.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_3.png.Database query G.37.11 error: Column 'dl_url_agsa' cannot be null

This is probably fixed now.  Please try again!

paolo

Quote from: AGA on Tue 01/01/2019 16:37:29
Quote from: paolo on Tue 01/01/2019 12:59:19
Looks nice, and the new server seems to be faster. Good work, guys.

I'm having trouble updating my game page: I get a load of warnings and errors when I click "Update" (see below). I suspect this is due to the migration as it wasn't happening before.


Warning: unlink(/home/ags/html//images/games/2313_1.png): Permission denied in /home/ags/html/pages/game.php on line 2372
Could not delete image 1: /home/ags/html//images/games/2313_1.png


Warning: move_uploaded_file(/home/ags/html//images/games/2313_1.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpyNvSSK' to '/home/ags/html//images/games/2313_1.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_1.png.
Warning: move_uploaded_file(/home/ags/html//images/games/2313_2.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpv2tgA6' to '/home/ags/html//images/games/2313_2.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_2.png.
Warning: move_uploaded_file(/home/ags/html//images/games/2313_3.png): failed to open stream: Permission denied in /home/ags/html/pages/game.php on line 2397

Warning: move_uploaded_file(): Unable to move '/tmp/phpL3eMTt' to '/home/ags/html//images/games/2313_3.png' in /home/ags/html/pages/game.php on line 2397
Could not save file as : /home/ags/html//images/games/2313_3.png.Database query G.37.11 error: Column 'dl_url_agsa' cannot be null

This is probably fixed now.  Please try again!

Thanks. Much better, although I get this error now (I filled in all compulsory fields):

Database query G.37.11 error: Column 'website_url' cannot be null

AGA

Game images and thumbnails should all be working as expected now.  As should the wiki.

Quote from: paolo on Tue 01/01/2019 16:56:16
Thanks. Much better, although I get this error now (I filled in all compulsory fields):

Database query G.37.11 error: Column 'website_url' cannot be null

Try again?  We might have to go back and forth a few times with this until I can get the database configuration working perfectly!

paolo

Quote from: AGA on Tue 01/01/2019 17:46:24
Game images and thumbnails should all be working as expected now.  As should the wiki.

Quote from: paolo on Tue 01/01/2019 16:56:16
Thanks. Much better, although I get this error now (I filled in all compulsory fields):

Database query G.37.11 error: Column 'website_url' cannot be null

Try again?  We might have to go back and forth a few times with this until I can get the database configuration working perfectly!

All good this time. Thanks!

CaptainD

AGA, I just want to say thanks for all your hard work doing the upgrade and sorting out issues - I'm sure the entire community is with me on this  :cheesy:
 

Monsieur OUXX

Great job!

One thing: the "download AGS" button here used to be twice bigger? Now it's rather small (it has like zero padding) and has a light color, as if it was disabled.

I'd suggest make it wayyyy more visible.
 

AGA

Quote from: Monsieur OUXX on Wed 02/01/2019 18:07:06
Great job!

One thing: the "download AGS" button here used to be twice bigger? Now it's rather small (it has like zero padding) and has a light color, as if it was disabled.

I'd suggest make it wayyyy more visible.

The reason for that is I have changed the old image based buttons to be dynamic, which means I'll be able to use them to do more dynamic, context based stuff.  I can't have gradiants or complex colours if I do that, so the button now looks flatter.  The text also has to be a standard, off the shelf font for the same reason.  If someone can do a design that meets those requirements, but looks better, I'd be happy to use it.

cat

Quote from: AGA on Mon 31/12/2018 14:16:08
Quote from: cat on Mon 31/12/2018 14:11:19
The Member Map seems to link to the old one and terribly out of date. I'd remove it completely.

The map linked to on the forums (https://www.adventuregamestudio.co.uk/forums/index.php?action=googlemap) is definitely up to date... How do you define "the old one"?  I think it may be the style changed slightly, but it's definitely using up to date information, and the latest Google Maps API.

In your profile page, the marker is in Rotterdam. But you are not shown on the member map there. If this member map requires to be updated separately by each member, I think it's quite useless. Either use the locations from the user profile or remove the link to the map.

AGA

Quote from: cat on Wed 02/01/2019 18:26:00
Quote from: AGA on Mon 31/12/2018 14:16:08
Quote from: cat on Mon 31/12/2018 14:11:19
The Member Map seems to link to the old one and terribly out of date. I'd remove it completely.

The map linked to on the forums (https://www.adventuregamestudio.co.uk/forums/index.php?action=googlemap) is definitely up to date... How do you define "the old one"?  I think it may be the style changed slightly, but it's definitely using up to date information, and the latest Google Maps API.

In your profile page, the marker is in Rotterdam. But you are not shown on the member map there. If this member map requires to be updated separately by each member, I think it's quite useless. Either use the locations from the user profile or remove the link to the map.

Ahhh.  Turns out there was a max 250 pins per map option.  So every page load it would pick 250 random members to show.  Sometimes I was included, sometimes not!  I've raised the limit now, and I'm visible without fail.

cat


Hobbes

Things seem to be running smoothly as far as I can see. Some issues earlier today, but they seem to be fixed. Thank you for all your time & effort in keeping this little part of the internet in good working order!

selmiak

Quote from: AGA on Wed 02/01/2019 18:16:50
Quote from: Monsieur OUXX on Wed 02/01/2019 18:07:06
Great job!

One thing: the "download AGS" button here used to be twice bigger? Now it's rather small (it has like zero padding) and has a light color, as if it was disabled.

I'd suggest make it wayyyy more visible.

The reason for that is I have changed the old image based buttons to be dynamic, which means I'll be able to use them to do more dynamic, context based stuff.  I can't have gradiants or complex colours if I do that, so the button now looks flatter.  The text also has to be a standard, off the shelf font for the same reason.  If someone can do a design that meets those requirements, but looks better, I'd be happy to use it.

these restrictions don't seem very dynamic :P
What about an image with a gradient as background image with some text over it? Gradients look good and css3 allows them! ;)

Yeah, thanks for making all the broken things work again and all the not so obvious improvements AGA :)

AGA

Fine by me, as long as it can scale as big or small as necessary, and still look unbroken!

Cassiebsg

Don't mind me, as I never go to the main page, but...
Why is there a huge blank space between the block to the left (download AGS, Make Games & Play games) and the one to the right? (recent news  (not very recent to be honest) and from the forum)??  And if I make my browser window fill less, like I normally do, the block doesn't follow to the left, meaning it "disappears" to the right.  8-0  :-[
There are those who believe that life here began out there...

AGA

Quote from: Cassiebsg on Wed 02/01/2019 22:00:05
Don't mind me, as I never go to the main page, but...
Why is there a huge blank space between the block to the left (download AGS, Make Games & Play games) and the one to the right? (recent news  (not very recent to be honest) and from the forum)??  And if I make my browser window fill less, like I normally do, the block doesn't follow to the left, meaning it "disappears" to the right.  8-0  :-[

Because I'm not very good at CSS!  On other pages it's more sensible, it's just not aligned very well on the front page.

LimpingFish

Bug report! I just noticed that thread prefixes (and the option to add them to posts) have disappeared from the Recruitment forum.

Other than that, I haven't noticed any major problems. Good work, AGA!  ;-D
Steam: LimpingFish
PSN: LFishRoller
XB: TheActualLimpingFish
Spotify: LimpingFish

dactylopus

A great deal of work has been (and continues to be) done here, and I wanted to say that I really appreciate all of the time spent improving the site.

Stupot

Good work, AGA. Thanks for taking the time to do this.

Not a major problem, but there's no longer that little thing in the bottom corner of text boxes that lets you expand the size of the box. I often find that quite useful.

AGA

Quote from: Stupot on Thu 03/01/2019 06:19:32
Good work, AGA. Thanks for taking the time to do this.

Not a major problem, but there's no longer that little thing in the bottom corner of text boxes that lets you expand the size of the box. I often find that quite useful.

On the forums, or main site?  Can you give some examples?  It's back on the forums now, at least.


Stupot

Quote from: AGA on Thu 03/01/2019 07:35:35
Quote from: Stupot on Thu 03/01/2019 06:19:32
Good work, AGA. Thanks for taking the time to do this.

Not a major problem, but there's no longer that little thing in the bottom corner of text boxes that lets you expand the size of the box. I often find that quite useful.

On the forums, or main site?  Can you give some examples?  It's back on the forums now, at least.


I mean the boxes that you can input a block of text, like the box I'm using to type this exact message. Here's what I mean, from a Moodle page:



Now this forum doesn't have that. There is now a thing running along the bottom but nothing happens when I click on it:




Snarky

I get both (Firefox on Mac), and I can drag that little double line down to expand the text box.

AGA

Yeah, the draggable line Snarky mentions was always there, and I just put the diagonal one back in. Do a hard refresh (CTRL+F5) if you don't see it.

It won't work on mobile though, since you can't drag.

Stupot

Thanks. It's working again now :-)

I always thought it was possible to drag it on my phone but it is also possible that I'm misremembering that.

CaptainD

Not sure if this has already been found, I tried to delete a comment on my game's page (it was about a sale that's been and gone so no longer relevant) and got a "Page incorrectly accessed." error.
 

AGA

Quote from: CaptainD on Thu 03/01/2019 11:55:20
Not sure if this has already been found, I tried to delete a comment on my game's page (it was about a sale that's been and gone so no longer relevant) and got a "Page incorrectly accessed." error.

Yeah, you aren't meant to be able to do that (and never have been). I'll fix the bug that shows you the option when I get home.

AGA

Quote from: AGA on Thu 03/01/2019 15:05:10
Quote from: CaptainD on Thu 03/01/2019 11:55:20
Not sure if this has already been found, I tried to delete a comment on my game's page (it was about a sale that's been and gone so no longer relevant) and got a "Page incorrectly accessed." error.

Yeah, you aren't meant to be able to do that (and never have been). I'll fix the bug that shows you the option when I get home.

Has the option disappeared now?

CaptainD

Quote from: AGA on Thu 03/01/2019 17:43:37
Quote from: AGA on Thu 03/01/2019 15:05:10
Quote from: CaptainD on Thu 03/01/2019 11:55:20
Not sure if this has already been found, I tried to delete a comment on my game's page (it was about a sale that's been and gone so no longer relevant) and got a "Page incorrectly accessed." error.

Yeah, you aren't meant to be able to do that (and never have been). I'll fix the bug that shows you the option when I get home.

Has the option disappeared now?
Sorry, still seeing it. Tried logging out and back in but it made no difference.
 

AGA

And exactly which game are we talking about?  Can't see any obvious cause why you're seeing this!

cat

I see it as well, I think because I have admin rights on the game DB (I sometimes help people fix their DB entries when they locked themselves out).
Maybe you have them as well? Some people were given those rights during one of those "fix screenshots and download links" activities.

CaptainD

Quote from: AGA on Thu 03/01/2019 22:05:55
And exactly which game are we talking about?  Can't see any obvious cause why you're seeing this!

https://www.adventuregamestudio.co.uk/site/games/game/2227/#comments

Just checked and still seeing it.  Does it make any difference that it's my own game?

Also some older comments seem to have disappeared (or, the "see older comments" link is just not showing?).
 

cat

The [ br ] and [ endsummary ] tags don't seem to work in the games DB description (Example: https://www.adventuregamestudio.co.uk/site/games/game/2314/).
However, just putting line breaks directly into the edit window works (Example: https://www.adventuregamestudio.co.uk/site/games/game/2316/)

AGA

Quote from: cat on Fri 04/01/2019 08:48:30
I see it as well, I think because I have admin rights on the game DB (I sometimes help people fix their DB entries when they locked themselves out).
Maybe you have them as well? Some people were given those rights during one of those "fix screenshots and download links" activities.

That was my first thought, but nope, CaptainD has none of those permissions (indeed none but 'normal user'...).  Being his own game shouldn't matter.  And weirdly, when I impersonate his user in my test environment, I see no delete option!  CaptainD, just to be sure, can you do a CTRL+F5 hard refresh on the page?  I made some small tweaks yesterday, so very surprised you're still seeing the delete option!

Quote from: CaptainD on Fri 04/01/2019 09:07:53
Also some older comments seem to have disappeared (or, the "see older comments" link is just not showing?).

On the game you linked in particular, there really are 'just' nine comments.  The logic was indeed broken on games with more than ten comments (e.g. https://www.adventuregamestudio.co.uk/site/games/game/269/#comments - the most commented game to date), which I've now fixed.

Quote from: cat on Fri 04/01/2019 09:13:18
The [ br ] and [ endsummary ] tags don't seem to work in the games DB description (Example: https://www.adventuregamestudio.co.uk/site/games/game/2314/).
However, just putting line breaks directly into the edit window works (Example: https://www.adventuregamestudio.co.uk/site/games/game/2316/)

Indeed the new WYSIWYG editor seems to work fine.  I'll just need to run a query to convert CJ's old BBCode syntax to real HTML.


Slasher

In game database, adding an ' or " results in getting \ as well...

CaptainD

Quote from: AGA on Fri 04/01/2019 19:58:21
CaptainD, just to be sure, can you do a CTRL+F5 hard refresh on the page?  I made some small tweaks yesterday, so very surprised you're still seeing the delete option!

I'm afraid it's still there.  Tried the hard refresh, also tried in a different browser.

I mean it's not a huge problem, it just means that there's an irrelevant comment about a special offer that's no longer active.  But it IS odd!
 

AGA

Quote from: LimpingFish on Wed 02/01/2019 22:47:16
Bug report! I just noticed that thread prefixes (and the option to add them to posts) have disappeared from the Recruitment forum.

Other than that, I haven't noticed any major problems. Good work, AGA!  ;-D

Fixed!

Quote from: AGA on Fri 04/01/2019 19:58:21
Indeed the new WYSIWYG editor seems to work fine.  I'll just need to run a query to convert CJ's old BBCode syntax to real HTML.

This is now fixed.  Linebreaks should show sensibly in all games' descriptions.

Quote from: CaptainD on Fri 04/01/2019 20:32:59
I mean it's not a huge problem, it just means that there's an irrelevant comment about a special offer that's no longer active.  But it IS odd!

Deleted the comment, and fixed the bug.  Now users can delete posts they themselves made (along with admins).

Quote from: Slasher on Fri 04/01/2019 20:08:04
In game database, adding an ' or " results in getting \ as well...

Sorry, can you give me an exact example of what you're doing to see this?  I've tried to work it out, but all results I see have just the intended symbols...

Slasher

Game Database.

'About this game' section

add  a "  see  \"  when saved

add an '  see  \'  when saved

cat


AGA

Quote from: Slasher on Sat 05/01/2019 05:54:11
Game Database.

'About this game' section

add  a "  see  \"  when saved

add an '  see  \'  when saved


Can you give me an example of a game page that has this?  I just picked a random one of your games that had a ' in the description text and couldn't see it.

Snarky

#67
1. Some of the MediaWiki macros (or whatever they're called) are broken in the Wiki. See for example the links to previous/following years on this page: https://www.adventuregamestudio.co.uk/wiki/AGS_Awards_2017

2. On the main forum page, the headers for each forum section say "Unread Posts" before the name. Is that how it's supposed to be, or some missing icon or something?

3. The simple forum search bar used to have a dropdown to limit the search to the current board/thread. That feature is gone. I found it quite useful; can we have it back?

Slasher

Quote from: AGA on Sat 05/01/2019 15:19:47
Quote from: Slasher on Sat 05/01/2019 05:54:11
Game Database.

'About this game' section

add  a "  see  \"  when saved

add an '  see  \'  when saved


Can you give me an example of a game page that has this?  I just picked a random one of your games that had a ' in the description text and couldn't see it.


https://www.adventuregamestudio.co.uk/site/games/game/2311/

Added to game description
"Made for Dec's Mag 2018."



AGA

1. Fixed.

2. This is actually intended behaviour (didn't it always look like that?), but I'm working to swap the text with the bluecup icon we see for unread posts.  Far more fiddly than you'd think!

3. I'm working to get the improved search functionality reimplemented, but it's massively unsupported these days, so it's quite possible it won't work.  At very least though, search is actually limited to the current context by default (i.e. within current topic, current board or current whole forum).

Snarky

Quote from: AGA on Sat 05/01/2019 21:25:47
1. Fixed.

Thanks!

Quote2. This is actually intended behaviour (didn't it always look like that?), but I'm working to swap the text with the bluecup icon we see for unread posts.  Far more fiddly than you'd think!

I don't recall. It's not a big deal.

Quote3. I'm working to get the improved search functionality reimplemented, but it's massively unsupported these days, so it's quite possible it won't work.  At very least though, search is actually limited to the current context by default (i.e. within current topic, current board or current whole forum).

That sounds sufficient; there isn't really a need for a dropdown, then. But it should probably be communicated: "Search forum/board/thread"

Great work!

AGA


Cassiebsg

About search:
Yes, cause I often use the search to search for topics, not necessarily just in the topic I'm currently at... so maybe an explanation on how the search works is needed? I always missed the option to search a specific part of the forum, like just "rumpus room" or "beginers..." or... Maybe it always did that and I didn't noticed?  8-0
There are those who believe that life here began out there...

AGA

Quote from: Snarky on Sat 05/01/2019 22:21:45
That sounds sufficient; there isn't really a need for a dropdown, then. But it should probably be communicated: "Search forum/board/thread"

Quote from: Cassiebsg on Sat 05/01/2019 22:37:40
About search:
Yes, cause I often use the search to search for topics, not necessarily just in the topic I'm currently at... so maybe an explanation on how the search works is needed? I always missed the option to search a specific part of the forum, like just "rumpus room" or "beginers..." or... Maybe it always did that and I didn't noticed?  8-0

I've added a dynamic label, so now it shows "Search Forums", "Search Board" or "Search Topic" depending on your context.

Cassiebsg

There are those who believe that life here began out there...

Khris

SSI.php is apparently missing from the test folder, and the forum theme has lost its stylesheet.

Mandle

Quote from: Khris on Thu 10/01/2019 00:35:46
SSI.php is apparently missing from the test folder, and the forum theme has lost its stylesheet.

Whew, I was worried that this might have been the new skin.=D

AGA

Sorry about that, deployment mishap.  That'll teach me not to do it right before going to bed at the end of a long day.

Snarky

I almost always get a 403 error when trying to preview (and often when trying to post) from Quick Reply. "Your technical support key is: c16e-2414-b40c-8ddc"

SMF spam blocked by CleanTalk