AGS High-Priority Improvement Needs

Started by fernewelten, Wed 26/05/2021 12:44:10

Previous topic - Next topic

Mehrdad

Hi @eriOo

Sorry for this question, How can use this file? Do I have to replace in a folder of the editor? Is it work with 3.6 too?
My official site: http://www.pershaland.com/

eri0o

#41
@Mehrdad, you use can rename it as acwin.exe and place in the directory with the Editor (AGS 3 Editor), or just use the Editor normally and run it in the directory that the game is built. Follow CW's instructions regarding the unicode translation file, using his test project.

Link to post with instructions: https://www.adventuregamestudio.co.uk/forums/index.php?topic=59170.msg636636892#msg636636892

It's built on top of CW's ags 3.6 utf-8 updates, so should work with ags 3.6 too!

Feel free to ask more questions :)

Mehrdad

Sorry but I didn't success yet. I got this pic


I use UTF-8 without BOM too. Is it related to "Windows System Locale"? It adjusted on Persian for me
My official site: http://www.pershaland.com/

Crimson Wizard

Quote from: Mehrdad on Fri 18/06/2021 08:21:29
I use UTF-8 without BOM too. Is it related to "Windows System Locale"? It adjusted on Persian for me

No, it should not be related to system locale.

Can you explain what did you do, or maybe upload your project?

Mehrdad

My official site: http://www.pershaland.com/

Crimson Wizard

#45
Quote from: Mehrdad on Fri 18/06/2021 08:56:49
It's the same as your project and I just added Persian.trs
Here you are
https://www.dropbox.com/s/9bvt8e9fibgf1wg/test--unicode_Persian.rar?dl=0

Your Persian.trs is saved as UTF-8 with BOM. You need to save it simply as UTF-8.

PS. That said, when this is done properly we may adjust translation compiler to check for BOM too, that would solve this inconvenience.

Mehrdad

Great. It works now!.
CW,  for the Persian language I need to turn on Right to Left in General Settings, and all of my words change like save and load the menu and so on. Is any way to change it only for talks?
My official site: http://www.pershaland.com/

Crimson Wizard

Quote from: Mehrdad on Fri 18/06/2021 12:30:35
CW,  for the Persian language I need to turn on Right to Left in General Settings, and all of my words change like save and load the menu and so on. Is any way to change it only for talks?

I know that you can turn it on for particular translation in TRS (find line //#TextDirection= ).
But unfortunately I do not think AGS supports setting this only for chosen lines.

I think eri0o suggested to be able to set this for individual fonts, which may be a good idea for the future.

Mehrdad


Quote

I know that you can turn it on for particular translation in TRS (find line //#TextDirection= ).


Ok, thanks. It works but it affects on GUI texts again like the same turn on Right to Left in General Settings.
My official site: http://www.pershaland.com/

Crimson Wizard

Ok, since this solution seem to have a potential, I opened the pull request:
https://github.com/adventuregamestudio/ags/pull/1321

If this works, unicode translations may be supported in AGS 3.6.0 already (fingers crossed).

eri0o

Here's where the Continuous Integration builds this PR if someone wants to pick up this for tests

https://cirrus-ci.com/github/adventuregamestudio/ags/pull/1321

Crimson Wizard

Quote from: eri0o on Mon 21/06/2021 01:10:13
Here's where the Continuous Integration builds this PR if someone wants to pick up this for tests

https://cirrus-ci.com/github/adventuregamestudio/ags/pull/1321

Oh right. "Editor_packaging" is the item that contains fully built editor + engine installer and zip.

SMF spam blocked by CleanTalk