Adventure Game Studio

AGS Development => Site & Forum Reports => Topic started by: Snarky on Sat 29/10/2022 09:03:46

Title: YouTube embeds
Post by: Snarky on Sat 29/10/2022 09:03:46
Just another example (https://www.adventuregamestudio.co.uk/forums/beginners-technical-questions/grestoregame-gui-problem/msg636650929) of how nobody understands the way embedded YouTube videos is supposed to work. Is it completely impossible to do anything about, so that it will accept a full URL rather than just the ID?
Title: Re: YouTube embeds
Post by: Cassiebsg on Sat 29/10/2022 10:18:20
Thing is that grabbing an url is easy and straight forward... figuring out what the video ID is, isn't. As far as I know there isn't anywhere one can copy paste the ID, except for analysing and dissecting the url...

I would rather just being able to enter the url as well, even though I know how to find the video ID and enter that.
Title: Re: YouTube embeds
Post by: AGA on Sat 29/10/2022 18:09:23
Quote from: Snarky on Sat 29/10/2022 09:03:46Just another example (https://www.adventuregamestudio.co.uk/forums/beginners-technical-questions/grestoregame-gui-problem/msg636650929) of how nobody understands the way embedded YouTube videos is supposed to work. Is it completely impossible to do anything about, so that it will accept a full URL rather than just the ID?

You're welcome to try...  Plugin is here (https://custom.simplemachines.org/index.php?mod=3982), and SMF core  here (https://download.simplemachines.org/).  I can give you access to the dev test forums if you have an idea of how to fix it.
Title: Re: YouTube embeds
Post by: Snarky on Sun 30/10/2022 07:28:18
OK, so it looks like the plugin tag is supposed to work with full URLs. So I suppose the first step is to set up a minimal test on a basic SMF install and see if it works at all; if so, the problem is presumably some aspect of the setup or a conflict with some other component.
Title: Re: YouTube embeds
Post by: AGA on Mon 31/10/2022 00:09:29
I think the issue is SMF 2.1 added support for [youtube] out of the box, which is probably affecting the plugin's more extensive use of the tag.
Title: Re: YouTube embeds
Post by: eri0o on Tue 01/11/2022 00:54:27
I briefly took a look at the plugin code, and the output div tags it uses in the forum for the youtube bbcode tag does not match what is seen in the forums when looking through the web browser source inspection, so my guess is the parsing isn't going through the plugin.
Title: Re: YouTube embeds
Post by: AGA on Tue 01/11/2022 21:58:43
I'd guess the native tag is catching the input instead of the plugin.  I haven't got the time or energy to look at it now, will look soon!

Title: Re: YouTube embeds
Post by: Khris on Tue 08/11/2022 13:09:38
I'd simply remove the plugin. SMF's native youtube button shows a small box where you can paste the URL, then it extracts and inserts just the ID.

The other functionality the plugin adds seems useless and broken anyway.
Title: Re: YouTube embeds
Post by: AGA on Fri 11/11/2022 20:14:22
Quote from: Khris on Tue 08/11/2022 13:09:38I'd simply remove the plugin. SMF's native youtube button shows a small box where you can paste the URL, then it extracts and inserts just the ID.

The other functionality the plugin adds seems useless and broken anyway.

Yup, seems to work, thanks!  It's now using the core SMF parser, which as you say makes it a bit more obvious how it should work.