AGS Editor (Version for testing)- Docking Panels

Started by tzachs, Sat 09/07/2011 23:48:50

Previous topic - Next topic

monkey0506

Using the "non-fixed" version, the error came up again. This is upon opening the editor, before the "Select game" dialog comes up:

QuoteError: Rectangle '{X=0,Y=615,Width=0,Height=20}' cannot have a width or height equal to 0.
Version: AGS 3.2.2.112

System.ArgumentException: Rectangle '{X=0,Y=615,Width=0,Height=20}' cannot have a width or height equal to 0.
   at System.Drawing.Drawing2D.LinearGradientBrush..ctor(Rectangle rect, Color color1, Color color2, LinearGradientMode linearGradientMode)
   at WeifenLuo.WinFormsUI.Docking.VS2005AutoHideStrip.DrawTab(Graphics g, TabVS2005 tab)
   at WeifenLuo.WinFormsUI.Docking.VS2005AutoHideStrip.DrawTabStrip(Graphics g, DockState dockState)
   at WeifenLuo.WinFormsUI.Docking.VS2005AutoHideStrip.DrawTabStrip(Graphics g)
   at WeifenLuo.WinFormsUI.Docking.VS2005AutoHideStrip.OnPaint(PaintEventArgs e)
   at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer, Boolean disposeEventArgs)
   at System.Windows.Forms.Control.WmPaint(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

cat

I can't start it. I get a file load exception (could not load AGS.Native). Do I need to copy some files somewhere?

monkey0506

@cat: Unless I'm mistaken the AGS.Native.dll should be included in the download, but even if it's not the Native assembly hasn't been open-sourced yet (that DLL is the only part of AGS currently not open-sourced). So, you should be able to copy it from the latest official AGS version without any complications since it logically can't have changed.

@tzachs: I tried to edit my post but apparently thanks to my poor internet connection it didn't submit the changes properly. The "fixed" version presents the same issue. The problem seems to arise if starting the editor with any panels docked to a screen edge, but hidden. I can send you my Layout.xml file if you need it. The only way I've found of correcting the problem (which is consistently persistent) is to open a project, pin or close any windows that were docked to a screen edge, save and exit, reload the project, and then I can unpin the items that I want hidden. I have to re-pin or close them when I exit though or the same problem comes up again.

tzachs

-- UPDATE --
New version now uploaded, with:
* New brilliant icons by the even more brilliant cat!
* Fixes (hopefully) for the two bugs reported by monkey_05_06

@monkey_05_06:
You have been incredibly helpful, I can't thank you enough.
- Your tip about running the game first, indeed helped me to reproduce the bug (finally), and now I hope it's solved. Let me know if you encounter this issue (or anything of that sort) again.
- The crash is now fixed too. I managed to reproduce it once or twice, but it didn't happen consistently, and it gave me a headache trying to figure out why. I finally realized that it only happens if you have a panel in the bottom in auto-hide, and if you hover your mouse around the bottom at the time the application loads (which you obviously like to do ;) ). It is actually a bug in the Dock Panel Suite itself, but I managed to work around that.

@ProgZmax: Thank you, and also thank Bernard from me...



cat

Seems to link to the repository  ??? and not the dll in the extracted folder:



(this is from the new version V4)

monkey0506

#25
The issue when loading the editor seems to be fixed, haven't tested the other one yet. ;)

Although there is another problem. What revision of the editor did you use to make these changes? I checked some changes in a while back, and they've gone completely missing from the SVN. I can't check them back in no matter what I try. Anyway, I'm secretly working on something that very specifically depends on some of those changes, and whether it was before I checked them in or after they somehow went missing, the changes don't exist in your version of the editor. :-\

Nevermind that. I was confusing myself because there is no engine code in the dev branch, so I was confusing that with the trunk.

However, there are some changes I've made in the current dev branch that I need for something I'm working on, and I would like to be able to use your version of the editor. I don't know if you checked out the trunk or the dev branch, but could you try and merge your revisions with the items I checked in to the current dev branch, please? ;D

tzachs

I've uploaded a new version.
cat, this version has some dlls that weren't in the original upload, so I think it should work for you now, please check and let me know.
monkey_05_06, this version also merges the changes you made to the branch.

monkey0506

Sweet. I made some latter revisions that I'm holding off on checking in because I'm not sure if there might be something else related to it that needs to be updated, and it would be silly to check in a partial fix. I say "fix" because what I'm talking about now is specifically a contradiction against the manual.

I can deal without those specific changes though as it's a non-essential subfeature of what I'm working on. The whole process would be rather expedited if the API I was using had proper documentation, but I'm figure it out. The dockable panels aren't specifically relevant to what I'm doing with that, but it will be nice to be able to get accustomed to it since I'm sure it will be accepted into the official version. ;)

Thanks man, and I'm glad that my bug reports were useful to you. Hopefully I'll be able to find..er..hopefully there's not any more, but if anything else crops up I'll let you know. :=

arj0n

v5:
Very small thing:
-Create a second room and edit it.
-Make it windowed.
-Edit room 1, Edit room 2, Edit room 1, Edit room 2, and so on.

Every time a room pops up in edit mode, it's location is not the same as its predecessor.

cat

Now it works! Hooray for resizable search result window!

tzachs

#30
@Arjon: Thank you, I uploaded a new version (version 6) with a fix for that issue.

@monkey: Awesome, I'll be waiting for a few days for more bug reports before checking in the code to the branch. Also, good luck on your secret project (I took a small peek to your checkin notes, so I vaguely know what it's related to  ;))...

@cat: Awesome x2... btw, if you (or anybody else) encounter this issue on some other future versions for testing, know that all you need to do is go to a version that's working and copy all files that are missing from the new version.
The reason this does work for some people, is (from what I've read) because if you have visual studio installed, then you don't need several dlls.

EDIT: And, I checked in the changes to the branch.

SMF spam blocked by CleanTalk