I decided to give the old walkcycle another shot to try and improve my animating:
(http://img478.imageshack.us/img478/7919/21400849wf3.gif)
To be perfectly honest, I think the arms look crap. But I've fiddled with them, pushed, re-sized, re-drawn... I dunno what I need to do to fix them.
All suggestions welcome.
Its very nice!
But, he seems to lean to the right with his upperbody all the time. So I think that he should lean to left with his upperbody to left more when he is stepping with his left leg.
I agree with MadReizka, the first thing I noticed was how he leaned more to the right when he stepped that way then on the left. However, I'm not going to say it's wrong, or it looks bad, it actually looks like a kind of swagger, or limp. That is to say, a unique walk at least. Good stuff. I didn't really focus on the arms until you pointed it out, and I don't know which one you're talking about or what is wrong with it.
I dunno what it is about the arms that bug me - maybe its just me being silly. Looking at it now, I think perhaps I need to make them a little longer, but I'm not sure.
The leaning sideways thing was kinda intentional. When I did the base sprite, I had him leaning sideways, and I thought it looked pretty cool so I kept it. I got sick of making walkcycles that are symmetrical.