Adventure Game Studio

AGS Development => Editor Development => Topic started by: Dave Gilbert on Mon 09/09/2024 13:47:53

Title: Request: More details on "FaceCharacter" error crash
Post by: Dave Gilbert on Mon 09/09/2024 13:47:53
Hello! Currently if you make a "facecharacter" command and one of the characters isn't in the room, you get this error:

(https://www.wadjeteyegames.com/temp/faceCharacter.jpg)

This error doesn't give me the script name or line number where the command was called, nor which character that is not in the room. Could those be added to the error message? It would save a lot of hassle.  :-D
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Crimson Wizard on Mon 09/09/2024 14:21:10
There are likely multiple error messages that don't give any details, or not enough.
I even opened a ticket for bringing them to a uniformity:
https://github.com/adventuregamestudio/ags/issues/1486
and suggested that this should be done systematically.

There should be rather a list of messages to fix, instead of a separate topic per each single message.

This list is easier to gather from the engine source code, where it may be searched for function calls such as:
"debug_script_warn", "quit", "quitprintf" and similar.
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Dave Gilbert on Mon 09/09/2024 14:53:21
Ah! Thank you. I wasn't aware of that.
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Crimson Wizard on Mon 09/09/2024 16:19:15
What bothers me about this particular case is that normally engine should have appended script location to this error, but somehow it did not.

EDIT: I confirm, script location is not posted, and it's not immediately clear whether this is specific to the given error. Could be it's broken for all error reporting in 3.6.1.

EDIT2: So, this was broken somewhere in the middle of 3.6.0 development.
Previously any such error would have a script line, but now it does not.
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Dave Gilbert on Mon 09/09/2024 16:42:23
I think (not at my desk now so can't confirm) if you get the error while in test-mode, it highlights the offending line of code. But if you're playing a stand-alone build, it just throws up the error.
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Crimson Wizard on Mon 09/09/2024 16:44:44
Quote from: Dave Gilbert on Mon 09/09/2024 16:42:23I think (not at my desk now so can't confirm) if you get the error while in test-mode, it highlights the offending line of code. But if you're playing a stand-alone build, it just throws up the error.

Yes, but it should also append a script line to the error message. It did so in previous versions, but not anymore since 3.6.0. There's a mistake in the engine that prevents that.

EDIT: okay, i fixed this one, should be in the next 3.6.1 patch.
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Crimson Wizard on Tue 10/09/2024 02:20:45
Here's the fixed version if you're interested:
https://cirrus-ci.com/task/4970957322846208
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Crimson Wizard on Mon 16/09/2024 03:06:26
This is fixed in 3.6.1 Patch 6
https://www.adventuregamestudio.co.uk/forums/ags-engine-editor-releases/ags-3-6-1-patch-6/
Title: Re: Request: More details on "FaceCharacter" error crash
Post by: Dave Gilbert on Thu 10/10/2024 13:55:35
Just saw this. Thank you so much!