Adventure Game Studio

AGS Development => Engine Development => Topic started by: Radiant on Sun 20/11/2016 21:04:36

Title: Patch for mouse glitch (Linux)
Post by: Radiant on Sun 20/11/2016 21:04:36
Some players report having issues with the mouse under Linux. It's been suggested that applying the following patch to allegro would resolve the matter.

https://sourceforge.net/p/alleg/bugs/396/

I'm not well-versed in building Allegro from scratch; could one of the developers here confirm this? If it works, maybe the package on teamcity can be updated? I'm currently using the master branch from Linux on teamcity.
Title: Re: Patch for mouse glitch (Linux)
Post by: Crimson Wizard on Sun 20/11/2016 21:44:17
Since we now have allegro repository cloned into AGS project group (https://github.com/adventuregamestudio/lib-allegro), we may apply this patch there and script build server to take Allegro sources from our repository instead.
Title: Re: Patch for mouse glitch (Linux)
Post by: Radiant on Sun 20/11/2016 21:52:15
That sounds good. Could you arrange a download of these pathced allegro binaries, then I've got a group of testers on standby.
Title: Re: Patch for mouse glitch (Linux)
Post by: morganw on Tue 22/11/2016 00:16:38
I'm pretty sure this was implemented before and it was removed, as it seemed to break the input queue rather than improve it.
https://github.com/adventuregamestudio/ags/commit/661637b070612bd8675d80b23d8f8b2bc6f4a864 (https://github.com/adventuregamestudio/ags/commit/661637b070612bd8675d80b23d8f8b2bc6f4a864)
Title: Re: Patch for mouse glitch (Linux)
Post by: Crimson Wizard on Tue 22/11/2016 08:47:00
Quote from: morganw on Tue 22/11/2016 00:16:38
I'm pretty sure this was implemented before and it was removed, as it seemed to break the input queue rather than improve it.
https://github.com/adventuregamestudio/ags/commit/661637b070612bd8675d80b23d8f8b2bc6f4a864 (https://github.com/adventuregamestudio/ags/commit/661637b070612bd8675d80b23d8f8b2bc6f4a864)
There were two variants of this patch - one to patch the Allegro, and another to patch engine code. The engine patch was the one which broke the input, so it was removed in favor of using Allegro one, which works well according to reporter.

https://github.com/adventuregamestudio/ags/issues/162
Title: Re: Patch for mouse glitch (Linux)
Post by: Radiant on Sat 26/11/2016 19:23:35
Ok, so the patch is already there. Does that also mean the compiled library is in teamcity somewhere? If not, which branch should I download and make?
Title: Re: Patch for mouse glitch (Linux)
Post by: Crimson Wizard on Sat 26/11/2016 19:58:58
Quote from: Radiant on Sat 26/11/2016 19:23:35
Ok, so the patch is already there. Does that also mean the compiled library is in teamcity somewhere? If not, which branch should I download and make?
No, we never added this patch to our sources; and build server still takes Allegro library from official repository.