Adventure Game Studio

AGS Development => Engine Development => Topic started by: Crimson Wizard on Wed 13/06/2012 20:14:27

Title: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: Crimson Wizard on Wed 13/06/2012 20:14:27
... a shout made years ago reached my ears today.

AGS code, acroom.h:
Code ("acroom.h") Select

void ViewLoopNew::ReadFromFile(FILE *iii)
{
#ifdef ALLEGRO_BIG_ENDIAN

  STEVE PLEASE VALIDATE THAT THIS CODE IS OK


Well, of course it is not OK; I never met a compiler that would understand such instruction.
And whoever is Steve, he did not even bother...




(laugh) :=
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: on Wed 13/06/2012 22:06:54
My sister's friend's uncle Steve* validates that the code IS okay. Stop worrying and start breaking your eggs on the right side  (nod)

___
* Stefan, actually.
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: Calin Leafshade on Wed 13/06/2012 22:24:05
That is almost certainly a reference to Steve McCrea aka Kweepa with regards to the PPC Mac port.
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: monkey0506 on Wed 13/06/2012 22:57:02
Calin, don't try to hide the fact that your name is Steve. :P
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: Kweepa on Thu 14/06/2012 15:16:54
Stupid PPC mac port.
I don't remember this code...
I don't recognize this code...
Look! A flame-haired journaliste on a police horse!
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: on Thu 14/06/2012 21:04:25
Quote from: Kweepa on Thu 14/06/2012 15:16:54
Look! A flame-haired journaliste on a police horse!

Where? Where??
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: BigMc on Thu 14/06/2012 21:25:16
I bet that line was written by should-have-gone-to-bed-a-long-time-ago Steve. Should better have left a Post-it for regular Steve. :-D
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: timofonic on Fri 15/06/2012 07:54:07
And this is one of the little examples about the reasons AGS code needs massive refactoring.

Did you grep the code for insults too? Let's compare it with the Linux kernel! :D
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: Calin Leafshade on Fri 15/06/2012 08:11:12
I'm not sure you fully understand the use of the word "refactoring"
Title: Re: STEVE PLEASE VALIDATE THAT THIS CODE IS OK
Post by: timofonic on Fri 15/06/2012 08:26:41
Quote from: Calin Leafshade on Fri 15/06/2012 08:11:12
I'm not sure you fully understand the use of the word "refactoring"

Yes, I'm aware of some computer programming terminology. Here are some references to stuff I did read about...

http://en.wikipedia.org/wiki/Code_refactoring
http://en.wikipedia.org/wiki/Code_smell
http://en.wikipedia.org/wiki/Anti-pattern