Topic: New Graphic Filter for AGS

[RyanBram]

Current version of AGS (3.2.1) has three graphics filter. Those are Nearest Neighbour (2x, 3x, 4x), and Hqx (2x and 3x). But I just read that there is a new filter called xBR (stands for Scaling by Rules) developed by Hyllian. xBR seems exceeds Nearest Neighbour and even Hqx in term of quality as shown in below screenshot :

Spoiler: ShowHide

I think it will be nice if AGS also incorporate this filter to giving better experience for players especially when playing low res games in HD screen.

The development thread can be found at: http://board.byuu.org/viewtopic.php?f=10&t=2248
And the source code (xbr.cpp) can be found at: http://sourceforge.net/p/paintown/code/7849/tree/trunk/src/util/graphics/sdl/
Standalone software can be seen at this thread: http://www.adventuregamestudio.co.uk/forums/index.php?topic=47954.0

Regards,

RyanBram

[Crimson Wizard]

That looks really nice and styly.
If there's an open source code, I believe it won't be difficult to add new filter to AGS.

I don't know if we are allowed to use the code under GNU GPL though (having engine under Artistic License). I apologise, but I am really not very well versed in understanding license restrictions and compatibilities  .

[SpeechCenter]

As far as I know, as long as AGS is not GPL it cannot incorporate GPL code.
I can think of 2 options:

• Ask the original author for an exception or a different license for AGS.
• Write the filter based on the algorithm and not use the original code.

Obviously option 1 is preferable if possible.

[RyanBram]

I don't know if we are allowed to use the code under GNU GPL though (having engine under Artistic License). I apologise, but I am really not very well versed in understanding license restrictions and compatibilities  .

Yeah, GPL and Artistic License 1.0  is incompatible that means either AGS or xBR should relicensing its software under compatible license. I contacted the author of xBR and fortunately he willing to re-license xBR source code under LGPL that means AGS can adopt it as external library/module without the needed to relicensing AGS itself.

I am very curious to see next release of AGS with this filter.


Best regards,

RyanBram

[zabnat]

I don't see the point of adding any other than nearest neighbor filters to the engine. I mean they only enable the user to make the game look like something different than what the author intended.

[DrJone.s]

These filters appeared as soon as TVs became HD and people tried to play low res games designed for old 625 scanlines models found out how incredibly ugly they looked in the new models. The effect caused by playing the old games in new monitors wasn't intended by the author, either.

[Sslaxx]

I don't know if we are allowed to use the code under GNU GPL though (having engine under Artistic License). I apologise, but I am really not very well versed in understanding license restrictions and compatibilities  .

Yeah, GPL and Artistic License 1.0  is incompatible that means either AGS or xBR should relicensing its software under compatible license. I contacted the author of xBR and fortunately he willing to re-license xBR source code under LGPL that means AGS can adopt it as external library/module without the needed to relicensing AGS itself.

But the AGS source code is licensed under version 2 of the Artistic License, which is. http://www.gnu.org/licenses/license-list.html#ArtisticLicense2

[BigMc]

Yes, but that would make AGS effectively GPL licensed. CJ doesn't want that: http://www.adventuregamestudio.co.uk/forums/index.php?topic=43383.0

[RickJ]

Here is what CJ actually said about the LGPL ...

http://www.adventuregamestudio.co.uk/forums/index.php?topic=43383.0

If you're thinking about adding third-party libraries, remember that AGS must not use GPL libraries as the GPL license is too strict. Libraries licensed under the Lesser GPL (LGPL) are ok, however. Always carefully read the license of any third-party libraries before proposing to use them in AGS.

[BigMc]

EDIT: Nevermind, I saw now that the filter will maybe be relicensed under LGPL.

[RickJ]

... fortunately he willing to re-license xBR source code under LGPL

[Monsieur OUXX]

Sorry for necroposting but I've rediscovered this and was pleasantly surprised by how active the developers have been, and how some of the filter's variations are available ready-to-use as shaders or as a standalone C code, etc. (see the UPDATES at the end of the page). They offer several levels of correction, depending on how much each variation fits with the style of a game.

If the license thing is not an issue, as it seems to be suggested above, then I'm still pushing in favor of adding the xBR algorithm. It could even allow to drop the other algorithms altogether (except nearest neighbour), which means less maintenance.

[selmiak]

xBR looks very smooth. Are we getting this?

[Knox]

Hi,

Sorry for re-opening this old thread, but I was wondering if a "bicubic" scaling filter would eventually be possible to add to AGS in the near future? It seems the two current options aren't giving great results when going full-screen (from 1600 x 900 to 1920 x 1080)