Messages

Hey, so I think I misunderstood the web api for saving blobs, I gave it the charset of windows-1252 and assumed it's going to encode it with that charset but it seems as though it still saves it as utf-8. There doesn't seem to be a simple built in way in javascript to convert encoding from utf-8, just the other way around.

Baguettator, a workaround can be just to take the output file and then use a different tool to convert the encoding. I found this website which seemed to work fine when I tested it with an output file.
Can you try to take the file you get from my website and feed it to that website and see if it works for you? i.e copy/paste the text to that textbox, select windows-1252, click "Calculate" and then the "text.txt" link? Let me know if that works for you.

To clarify, Windows 1252 is not a format, it's codepage. Format is ANSI.

Sorry, can you expand on this? It confused me, looking here it seems Ansi and Windows-1252 is pretty much the same thing?

But, I never used tzach's application or seen its code

If you're interested, code is here.

@Baguettator, I uploaded a new version which has a drop-down to select the encoding for your file. If you select "windows-1252" then it should show correctly for your file. What I'm not sure about is whether saving the file will work as expected with AGS, let me know if you're still having issues.

Thanks @Baguettator, I was able to reproduce the problem with that file.

The problem is that the translator assumes the file is encoded in UTF-8, but your file is encoded in Windows-1252.
It seems that AGS uses whatever encoding is set in your machine, which is actually not great, as it means that if you export translation on one computer and import it on another you might have these types of issues as well (or even on the same computer if you switched the encoding). The best thing would probably to always use the same encoding (i.e UTF-8) but doing that now will break current exported translations for people.

Anyway, I tried auto-detecting the encoding of the file but the scripts I found for that were unreliable, so I'm going to add a drop-down for selecting the encoding which should then fix it. I'll update when it's ready.

Thanks @Baguettator, I tried to reproduce on Windows 10 with Firefox 84.0.2 (64-bit) but it still worked fine for me.

The fact that the editable text field works for you but the readonly label doesn't is a heavy hint that the issue is related to how those letters are encoded in your file, so I can't proceed unless you send me your file to debug (or @Creamy or somebody else that can reproduce it sends their file). One way to send the file is to upload it somewhere (like dropbox) and then send me the link. If you're worried about sharing your game text, you can cut out all but 1-2 lines (but check that the problem still persists with the new file).

Thanks.

Hi @Baguettator, sorry, just saw this now.
I can't reproduce this error, if you still need help, then I have some questions:
- What OS (and version) are you running on?
- What browser (and version) are you running on?
- Can you supply a sample trs file that shows the problem?
- Do other websites with those characters appear normal in your browser?
- Is it both the text field and label which has this problem, or just one of them?

Sorry for the delay (like SpeechCenter, if I'm unresponsive send me a PM).

The "show all unread topics" button used to show just the topics that have new messages from the last time I browsed the website. Now I'm getting a list of all topics (I think). I use this feature exclusively, so I can say it broke recently, like in the last week or so.

Spoiler

cover

[close]

If the helperText solves the problem, maybe it would be worth using it for all lines? Two reasons I can see this as an advantage is: consistency (the original line is always in the same place) and those that want to use the phone (maybe they've got some time to kill somewhere, and their phone is right there) can use it without trouble. But I don't know if there's an advantage over the other. 

I considered it, but it doesn't look as nice (i.e you'll lose the text compaction when there's no translation for the line and the nice animation that goes with writing text in the field). I think that the long labels that break the layout are very rare so that breaking the consistency, while not ideal, is not a big deal.

Seems kind of weird that they don't want to support long labels though. Why limit a tool this way? Being pig headed? 

I think it's a "for the greater good" decision. The use-case for such long labels is very rare, and fixing it increases the complexity of the code in a way that future features will be harder to develop and it risks creating more bugs for the majority of the users.

EDIT: Weird... I've sat to do a few lines, and now the spellchecker isn't turned on. I have to turn it one for every single line now!  This wasn't happening before, once I turned it on it would be on for all lines on the page. I'm not sure why this is happening now. Did disabling the Enter key did this? Or was it the helperText? Or something else?

Definitely not the helperText, but switching from multiline input to single line input, unlikely, but maybe? Browsers might have a default of whether they should spell check or not, and it's on for multiline and off for single line? A very wild guess on my part. Anyway, I tried to explicitly enable spellchecking on the controls, let me know if it improves the situation.

As for the jump feature, I managed to make it jump, and then it stopped working again. But like I said, I can just scroll up/down as needed. EDIT3: Uhm... if I add a space to the search box, then the jump works! 

Oh! I had a bug when clearing the search (I forgot to clear the mapping between the real line index and the line index that passed the search). So after clearing the search jumping lines might have been broken. I fixed the bug, hopefully that was what you were experiencing.

Also the search function seems to find only the first line that word is used.  (EDIT2: Oh, it's case sensitive! Not sure this is the best choice to use in a search box though.  )

Changed the search bar to be not case sensitive.

Have to delete the text from the search box and then I'm back at the top on line 1 (even if the found line was 148 and I was on line 1735 when I performed the search).

I changed it so the editor will try to keep you in the general whereabouts of where you were when changing the search (doing it accurately is very tricky, but it should be somewhere in the ballpark).

[not]

Uhm, funny. I was pretty sure I tested the line jumping function when you posted it was done.
But I'm currently using it to do a translation and just noticed that when I click the jump button nothing happens. 

I can't reproduce this on latest firefox. I tried to download your version but it crashes on my machine so I don't have a solution for this.

EDIT: I found a BUG!
If I hit ENTER the editor will add a new line. We do not want the user to be able to add new lines. Is it possible to make it detect the enter and just make it jump to the next line to edit? Like the TAB does?

Oh, I actually went into trouble to support multiline inputs.. Ok, fixed (enter does nothing now- it's technically possible to make it behave like a tab, but too much work I think for supporting this compared to the benefits).

There's another one, but I'm not sure if it's possible to fix or how. If you have a very long line (because it's a long text that is being displayed by a label), the original will "bleed" into the line to type in. Making it hard or impossible to see what one is typing. (Maybe remove line warp and just let the line be as long as needed?)

So, I'm using material-ui TextField's label for this, and they don't want to support long labels by design (see here: https://github.com/mui-org/material-ui/issues/12255), and they don't support not wrapping either. So I changed it to use "helperText" instead of label if the text is long, which means the text will appear in the bottom instead the top but it will not break the layout and you'll be able to see it all. It's not perfect, though, I just picked a random number (200 characters) which looked good on my machine, but your results might vary (it will definitely still look wrong if you use a phone in portrait, for example).

Spoiler

And I would guess that RC stands for RC Cola, and I also see Pepsi, Coca Cola and Dr Pepper...
So I'm guessing "drink" or "fuzzy"?

[close]

Spoiler

pixel?

[close]

Correct!

Ok, my attempt for a riddle, hopefully not too easy:

You'll find it on your screen. Perhaps written somewhere, but if not, it's still there, just look closely.

I will post a new puzzle here for the meanwhile if that is alright with everyone...

16, 15, 24, 39, 13.

Spoiler

enema?

[close]

        CAGE CAGE CAGE
        LOCK ear   CAGE
        CAGE CAGE CAGE

Oh my god, the bear is gone, and.. WHAT THE HELL IS THAT?

Sorry that I use an old browser... but it's like every time Firefox updates the browser they ruin something I love in it and take control from me to their own automatic crap. And I don't like relinquishing certain things.

I figured it was something like that. But actually it's not that old, March 2018 is still reasonable, I feel.

I do feel this text should be added somewhere:
- If you don't want to translate a line, just leave the following line blank.
- Lines starting with '//' are comments - DO NOT translate them.
- Special characters such as [ and %%s symbolise things within the game, so should be left in an appropriate place in the message.

Ok, added the text, with the exception of the comments line. I think it's irrelevant in the context of the editor, the comments will not be displayed so you won't be able to edit them either way.

But also, very cool that it runs on the browser, since I have spell check on my browser, that solves that problem (at least for me, no idea how spell checking works in other browsers). 

Yes, that's one of the reasons I figured web would be a good fit (also undo/redo without effort). The spellcheck kind-of-works on chrome, but it's a hit or miss.
Also not sure how the spellcheck works for other languages which are not in your browser's preference. It might be possible to improve the experience (maybe there could be a language selector that sets the spellcheck for that language or something like that - I don't know if that will help).

So, from my original request, the only thing missing is the ability to jump to a line, by typing 808 and jumping to line 808.

Added.

Thanks again for doing it, I can see a lot of devs and translators being happy with the tool and saving them countless hours of headache trying to find that character that ruined the formating by accident. 

I tried and saved the file, to compile it. It saves as ags.trs, maybe it could ask to enter file name? Not a big deal though. it's easy to change the file name afterwards.

This depends on the browser. Chrome does ask you to enter a filename.

Also noted it adds an empty line at the top of the file. I tested compiling it with the empty line and the translation seems to work fine with it. So not a big deal, if it's too much work to remove it.

Fixed.

Again, super work! Maybe ready to be posted for others in here to know and start using it?  (not sure how many read the Engine Development forum).

Thanks! And feel free to spread the news!

This error seems to be reported: TypeError: this.props.from.trimStart is not a function (23 errors of this kind)

Ah, seems trimStart was only introduced in Firefox 61. I fixed it (and I downloaded firefox 59 to see that it works on it after the fix).
I also fixed the other issue I mentioned before.

But when I do load it, all I get is still an empty page.

Hmm, can you try opening the console and see if there are any errors there?
https://developer.mozilla.org/en-US/docs/Tools/Web_Console/Opening_the_Web_Console

The editor seems to work but I have one big feature request: I cannot search for strings in the whole file. I assume the web server streams the content, so searching is limited to the part which currently is transmitted. And line numbering would be great.

I added search and line numbering (there's currently a known issue though that if you search it screws up the navigation buttons, I'll fix that hopefully tomorrow).
Just as FYI: it's not that the web server is streaming the content, the client has all of the information, it just doesn't render it because that would be too slow, so the browser can't find it on its own.

Thanks for the sample files, it should work now if you want to try again.

(Yes, you should click the load icon and select a trs file).

I made a small web app that I think meets most of your requirements: https://tzachshabtay.github.io/ags-trs-editor/

I never worked with trs files myself, and I guessed at the format, so if it doesn't work for you, send me your file so I can fix it.

- Box/help displaying the trs warning about characters and such (optional)

I didn't know what that means so I didn't do it.

I'm very sad to hear this 
RIP Ghost.