The paper-under-door-to-get-key-puzzle is way older than adventure games. I remember reading it in a children's detective book that was written in the fifties.
I think any puzzle can work excellently if presented in a good context and for a logical reason. Any puzzle can be awful if it's just random and illogical.
Some typical puzzles (or puzzle-types, really) I don't like:
* Pixelhunting. It encourages the player to click everywhere on the screen not to miss something, and it ruins the gameplay.
* Repetative clicking. Ok, so if I click on the character a fourth time, he'll tell me the secret.
* Extremely realistic/technical puzzles. Like "use knife to remove isolation from cable, use pliers to twist cables around eachother, combine batteries with screwdriver, etc etc". Heck, if I want to mend a radio, I can do that in real life.
* Surprise-effects-puzzles. This is quite common even in professional games. Items have hidden qualities that don't make sense, and to discover the effect you must try everything on everything, and that also ruins the gameplay. For some reason, Space Quest comes to mind, even though I can't point out a specific puzzles right now.
I think any puzzle can work excellently if presented in a good context and for a logical reason. Any puzzle can be awful if it's just random and illogical.
Some typical puzzles (or puzzle-types, really) I don't like:
* Pixelhunting. It encourages the player to click everywhere on the screen not to miss something, and it ruins the gameplay.
* Repetative clicking. Ok, so if I click on the character a fourth time, he'll tell me the secret.
* Extremely realistic/technical puzzles. Like "use knife to remove isolation from cable, use pliers to twist cables around eachother, combine batteries with screwdriver, etc etc". Heck, if I want to mend a radio, I can do that in real life.
* Surprise-effects-puzzles. This is quite common even in professional games. Items have hidden qualities that don't make sense, and to discover the effect you must try everything on everything, and that also ruins the gameplay. For some reason, Space Quest comes to mind, even though I can't point out a specific puzzles right now.