Messages

@LauraHunt, here's the fixed build:
https://cirrus-ci.com/task/6597896589017088

Works like a charm, thank you!

[Edit]

Could you send me a script that causes the problems, and a font?

I'll PM you the link in a second.

Also, what is the locale for non-unicode programs set on your system;

English-US.

and what locale is mentioned at the top of the Game.agf, where it sais "encoding"?

Windows-1252.

Just to double check, I did a quick test importing the same fonts in a game made with AGS 3.5.1, and I don't seem to have any issues there.


Edit: I changed my system locale for non-unicode programs to Spanish just to check if the issue would still happen, and it didn't make a difference.

[in any non-room scripts]

I've done some more testing, and it turns out it doesn't have to do specifically with custom text properties. Any extended characters in any non-room scripts will display the same issue.

So if I simply do player.Say("My name is Lucía"); in the Global Script, it will get displayed as "My name is Luc?a".

If I change anything in that script, even if it's just adding a commented line like //this is a comment, the issue is fixed temporarily untl the next time I open the engine.

When you say "next time I open the engine", do you mean "editor"?

Yes. I save my game, close AGS, I open AGS again, load my game, and the issue is back.

Overall, this sounds as the problem is in reading the scripts from the file and/or writing them back to file. As when compiling the game editor probably uses the scripts in memory if available, so when you edit the script, the version in memory gets fixed, but if they are not memory and loaded from the file - then a broken version is used.

The interesting thing is that if I switch to Unicode, the wrong character being displayed is ^, not ?. So it will display Luc^a rather than Luc?a. It's almost as if the engine is not able to render or access the extended ASCII characters after 127 for some reason, but only for those specific scripts. Room scripts work fine.

So, two things should be tested: how the script is saved and how it's loaded. Can you open the script in a separate text editor and see what encoding is it saved in, and if the letter is correct there?

Notepad++ confirms all the scripts are ANSI. Everything looks correct there.

Additionally, do you use any editor plugins, or any extra tools, which may affect a script file?

Nothing. No plugins or extras, just script modules (rellax, tween and my own auxiliary scripts).

[in any non-room scripts]

Please tell, how do you display it precisely?

I've done some more testing, and it turns out it doesn't have to do specifically with custom text properties. Any extended characters in any non-room scripts will display the same issue.

So if I simply do player.Say("My name is Lucía"); in the Global Script, it will get displayed as "My name is Luc?a".

If I change anything in that script, even if it's just adding a commented line like //this is a comment, the issue is fixed temporarily untl the next time I open the engine.

As to your questions:

Does it display correctly in the editor, or it gets broken in both text editor and game?

It displays correctly in the editor. It's only broken in-game.

Could it be that while in game you restore some previously made save, which has this property value stored in an incorrect way?

There isn't a save system implemented yet, so every time the game runs, it runs from scratch. I'm not saving or loading anything.

PS. I rather recommend switching to Unicode mode regardless, as that might resolve all text problems now and in the future.

That's not really possible now, because I started working on this game with AGS 3.5.1 and all the fonts I'm using for this game use windows-1252 extended ASCII encoding. Changing fonts at this stage of the project is not really an option.

I'm having an issue with text properties apparently not saving their text encoding properly. I'll try to explain step by step as thoroughly as I can.

Context:
- I'm using AGS 3.6.0.30, Beta 10.
- My game is in ASCII/ANSI, and I've never switched it to Unicode.
- I'm not using translations. This is text written directly in the editor.
- All letters with accents display properly elsewhere in the game. I only have issues if they're in a custom text property string.

I have a name with an accent ("Lucía") in a text property whose value I define via an auxiliary script like this:

Code: ags

object[27].SetTextProperty(OBJ_ITEMNAME, "A photograph of Lucía.");

(OBJ_ITEMNAME is a constant whose value is "obj_itemname"; I always do this so that autocomplete will work for custom properties.)

When I start my game, Lucía is displayed as Luc?a.

However, if I delete the "í" and write it again, it is now displayed properly. I rebuild all files just to be sure, and save my game.

But when I start up AGS and run my game again, the issue is there again.


(Unrelated: I had the same issue as Baguettator with fonts being cut at the top of labels, and switching the TTF font adjustment value to "Do nothing" did indeed fix it.)

Hmmmm turns out I haven't watched any shows recently, so I don't have anything. Heltenjon, do you want to take over?

Could it be Ash vs. Evil Dead?

My few cents:

- I've never known who that "Larry" was or what it was referencing, and I guess it's the case too for relative newcomers. It gave me the impression of being some sort of inside joke that I was not in on and as such, it felt like a weird choice for a "mascot".

- Not feeling the manga/anime look of the girl either. That kind of aesthetic is more commonly associated with RPGs or visual novels, rather than with point and click adventures.

- The logos with a single cup look much cleaner and elegant than the one with three cups.

If there was to be a mascot in the logo, the obvious choice would be an anthropomorphic blue cup, would it not?

Or... hear me out... a CUPYBARA. I'll show myself out.

Is that movie any good guys?

The Wailing? I liked it a lot. When I saw it was 2.5 hours I assumed it would be a really slow burn, but it's actually not the case, the pacing is really good and you never get a feeling of "come on, just move along already". Definitely recommended.

Up next:

Ah, I know this one. I'll leave it for someone else, though.

Yes, she did throw all those stones! And it's a Korean movie indeed, but not Parasite.

As per usual, 1 guess = 1 new screenshot:

Something I watched recently:

Since nobody seems to know the answer, I'll go ahead: it's Valerie and her Week of Wonders.

Actually the gif is pretty misleading, because it's not a black and white movie.

And it's not japanese either. It's Czech.

Yeah, I mentioned it way up in the second post. The first movie is one of my favourite films of any genre. The second is basically more of the same, so I enjoyed it. I frankly hated Rec 3 and thought it was utter toilet, but maybe I was in the wrong frame of mind on the day. Rec 4, I watched in Spanish with Japanese subititles and still absolutely loved it.

The second one was also really good, yeah. I never bothered with the third one because it wasn't directed by Balagueró, and from the looks of it I really didn't miss out on anything.

[[REC]]

The Borderlands is so good! I totally second the recommendation. And I've heard great things about Lake Mungo, but I haven't gotten around to watching it so far. Maybe this is a sign that I should check it out already.

Since it doesn't look like it's been mentioned yet, maybe it's an obvious choice but I remember liking [REC] a lot back in the day. I'm not sure how well it might have aged, but it's probably worth a shot in any case.

I think you're missing a null check. I haven't tested this, but maybe try something like this?

There's no need for a null check when you are comparing a pointer value.

Code: ags

  if (tempbutton != bBegin)

This will also cover null value, because if tempbutton is null, then it's already not equal to bBegin

True. Sometimes I tend to be super conservative with my null checks, but you're right of course, in this case it wouldn't be necesssary. eri0o's suggestions are probably on the right track.

I think you're missing a null check. I haven't tested this, but maybe try something like this?

Code: ags

function room_RepExec(){
  Button* tempbutton = GUIControl.GetAtScreenXY(mouse.x, mouse.y).AsButton;
  if (tempbutton == null || tempbutton != bBegin) bBegin.TextColor = 65535;    
  else bBegin.TextColor = 63488;
}

I saw this one not too long ago. I'm pretty sure it's Dr. Terror's House of Horrors.

Correct!



It's pretty bad overall, to be honest, but the idea of "several people telling stories on a train bound to hell and a mysterious figure who could be the/a devil or Death himself" was the starting point for If On A Winter's Night, Four Travelers! (In case it wasn't obvious )

Over to you!

OMAM! (*) How didn't I recognize this?

(*) Oh my Alanis Morrisette!

Hahaha

Alright, here's mine. I have the weird feeling that I might have posted this movie already a long time ago, but there it goes anyway.

My love for you is like a truck, BERSERKER!
Would you like some making fuck, BERSERKER!

Ahm, anyway, it's Clerks