Bug with Save Box

Ytterbium · Thu 15/01/2004 20:35:21

I decided to change the "Cancel" global message that appears on the default Save box to give it more personality. Now clicking this button gives me this error:

An exception 0xC0000005 occured in ACWIN.EXE at EIP = 0x414C4D41 ; program pointer is +6, ACI version 2.56.627, gtags (0,3)

I'm not sure if it did it before changing the message, but either way, this is bad.

Gilbert · Fri 16/01/2004 09:21:27

Hmmm did you use "non-standard" characters in the message (any characters beyond ASCII #127, eg. the accented characters), if there're such characters, try removing them from the message and recompile, and check if they're the cause of teh crashes.

Ytterbium · Tue 20/01/2004 00:51:06

Quote from: Gilbot V7000a on Fri 16/01/2004 09:21:27
Hmmm did you use "non-standard" characters in the message (any characters beyond ASCII #127, eg. the accented characters), if there're such characters, try removing them from the message and recompile, and check if they're the cause of teh crashes.

I used 1 and exclamation points (don't ask). I don't think those count as special characters.

And it only happens with save, not load.

Gilbert · Tue 20/01/2004 01:50:48

Try modifying the message first, if the game still crashes, then it's not that problem, and we can invest more on it.

Ytterbium · Tue 20/01/2004 20:36:57

I changed it back to Cancel, and it still crashed.

Scorpiorus · Tue 20/01/2004 21:59:30

Then it might be probably something else. I think we need to wait for CJ to look at the exception message.

Pumaman · Sat 24/01/2004 20:29:16

Could you make a backup copy of your game and try upgrading it to 2.6 SP1, and see if it works then - just to make sure we don't waste time chasing a bug that has already been fixed.

Ytterbium · Sun 25/01/2004 23:02:46

Quote from: Pumaman on Sat 24/01/2004 20:29:16
Could you make a backup copy of your game and try upgrading it to 2.6 SP1, and see if it works then - just to make sure we don't waste time chasing a bug that has already been fixed.

Still does it when I upgraded.

Pumaman · Sat 31/01/2004 13:59:14

How big is the game? Any chance you could upload it for me to take a look at?

Ytterbium · Sat 31/01/2004 14:45:49

Quote from: Pumaman on Sat 31/01/2004 13:59:14
How big is the game? Any chance you could upload it for me to take a look at?

It's about 15 megs, but I can give you an older, 7 meg version (which still has the save bug problem, though not compiled with 2.6 SP1).

Where can I email it to? There's not enough room on my ftp.

Pumaman · Sat 31/01/2004 15:00:20

Could you try mailing it to cj@agsforums.com although I'm not sure if it'll accept an attachment of that size.

Thanks.

Ytterbium · Sat 31/01/2004 16:27:11

It's been sent.

Darth Mandarb · Sat 31/01/2004 16:35:30

I got this same error two days ago.

I got it when I put "NewRoom(11);" into my global script before the first room loads.

Once I removed that, it didn't error on me any more.

I just assumed it gave me that error because my character starts in room1 and I told it to go to room 11. But either way, that's the error I got.

Pumaman · Sat 31/01/2004 17:31:53

Thanks for sending it.

The bug is a very sloppy buffer overrun problem in the save game dialog, if the message you use in replacement of "Please type a name for the save" is too long.

Ick, I hate looking at the code for the save/restore dialog boxes, they are the only bit of code from AC v1.00 that I kept on in AGS and it shows. Anyway, I'll get it fixed for the next version - but until then, it's probably best to put the "Type a name to save as" message back to how it was, and also put the Cancel button back to "Cancel" because I think there's an overrun there as well if the text is longer than 10 characters.