[AGS4 feature request] Proper shortcuts, proper search

Started by Monsieur OUXX, Today at 11:43:43

Previous topic - Next topic

Monsieur OUXX

Suggestions :

1) A separate shortcut for "search al files" and "search this file".

At the moment, pressing Ctrl+F opens the search dialog box. It is set on "Current document". In order to search all documents, the user has to press "Tab" followed by "down arrow".
It would be better if there was two separate shortcuts, which would either open this popup window directly on "current document" or directly on "current project".
Note: Unfortunately Shift+Ctrl+F is already taken by "Find All" which has a different meaning (it produces a list of results).

Which leads me to...

2) "Search this document" should have its own, smaller GUI control

Look at how it's done in VSCode or IntelliJ or other UIs. When searching the currently-open document, the search box is a tiny widget in the top-right corner of the open document. The "Look in" dropdown does not exist because it is accepted that it will search only here. the "case sensitive" tick box is just a small button with an icon. The "find next" button is just an "arrow down" icon, with F3 as a shortcut.
"Replace" would be the same widget but with an extra textbox underneath, for the new text.

Which leads me to...

3) (MAYBE) "Look in current project" (i.e. "search all files") should just be the "Find all" which I mentioned before.

The popup window could disappear entirely.
This one is a bit trickier than the to previous suggestions because I'm not sure how "replace all" would work in that situation. Don't spend time on this.


All in all, the center of the suggestion is to make "search all files" immediately accessible.

And an extra suggestion :

4) Add a shortcut for opening a script by name OR add filter to tree items

Now, an AGS game can have many script files.
In VSCode and IntelliJ, there's a shortcut which opens a textbox (Ctrl+P in VSCode). You start typing the name of a file in the textbox. It offers suggestions of files (scripts) that match.You select the file you want, you press enter, it opens it.
ALTERNATIVELY, add a small search textbox on top of the game tree (in the Editor's right panel) and let the user filter on that name. Of course it would search in tree items that are not currently expanded, otherwise it defeats the purpose.

At the moment, the two available flows are :
a) Shift+Ctrl+G to open the global script, then Ctrl+F to open the search, then Tab followed by arrow down to select "current project" (i.e. search all files), then press "find next" or use right-click+Go to definition, to open the wished script.
OR
b) click in the list of items in the right-side panel of the editor, and type the first letters of the script. It will select it IF IT'S OPEN (i.e. visible) IN THE GAME TREE.


Finally:

5) (BUGFIX) Fix the scrolling to the highlighted line of code

I'm working with a very wide screen (3840x2160). When I search for text in a file, it often happens that the highlighted result is actually outside of the file's viewport (i.e. a few lines of code below the last line of code currently visible). In other words: The search doesn't make the file scroll low enough to see the result.

I know these kind of issues are not easy, because there's a lot of geometry and assumptions involved. It can probably be reproduced by opening the AGS Editor and resizing the window to be short but very wide.

 

Crimson Wizard

Quote from: Monsieur OUXX on Today at 11:43:435) (BUGFIX) Fix the scrolling to the highlighted line of code

Please, open bug reports separately from the new feature suggestions. Usually they are dealt with separately and have separate targetted releases.

SMF spam blocked by CleanTalk