Messages

ResetRoom() does not change global variables.

Indeed, ResetRoom was never supposed to change anything global.

There's one known case which may result in "loosing" global variable value: it's when you declared variables in the header without "import" keyword. This leads to variable "duplication" effect, where each script, including room script, receives a copy of a variable instead of using same shared one.

https://adventuregamestudio.github.io/ags-manual/TheScriptHeader.html

When I just found AGS I had no idea what to look for, so started playing games in alphabetic order, choosing ones that looked fine on screenshots and had average+ rating.

Naturally, most of Yahtzee's games were there, because they had numbers in titles ("1213", "5 Days a Stranger", and so forth). Then "Alien Time Zone" by Babar and "Apprentice 1,2". Then "Ben Jordan" series. And so forth.

Here's a temporary build with a number of fixes applied:
https://cirrus-ci.com/task/4911341614399488

I'm posting this for an extra test before making an official new patch.

Fixes include (but not limited to):
- Fixed in script editor character literals having wrong style when a custom theme is applied;
- Fixed TextWindow edges drawn under the corner pieces;
- Fixed screen flashing black once after a video playback;
- Don't check number of audio clips when loading a legacy save format (made before 3.5.0);
- An option to disable language selection in Winsetup ("[disabled] translation = 1");
- Filter names under "[disabled]" section in config are treated in case-insensitive way;
- Print a warning into game log when a blocking Display or Say is called while game is fade-out;

Yes, apparently it's another mistake in docs.

I'm fine with none and stdscale; and I want to disable linear.

(edit) I suppose I could lock it to stdscale, and assume that stdscale with a scaling of 1.0 is identical to no scaling.

In the contemporary engine there's no such thing as "no filter", there's always a filter setting, because window is now freely resizable.
This is also why "scaling" and "filter" options were separated. The "scaling" option only tells the starting scaling.

On another hand, is not listing which filters to disable is opposite to what the user's intention is?
If intention is to lock particular filter, then this is what should be done instead.
Currently this may be done by setting filter in config, and doing

Code: ags

[disabled]
filters=1

[keys]

So, yes, it's a horrible mess now. The filter and gfxdriver IDs are treated as case-insensitive in one case, and as case-sensitive in another. The docs and engine help mention them all lowercase, while the actual IDs are camelcase. I should have paid more attention to this earlier.

EDIT: the part of the problem is that filter names are used as config keys in "disabled" section. If they were used as values instead, that would solve the issue for the time being.

I.e. if it were "filters=name,name,..." instead.

How do you figure? None of "linear", "Linear", "LINEAR", "Linear interpolation", "Linear_interpolation" or

There's another mistake in this documentation, it has to be

Code: ags

Linear=1

everything is in mess here.

So, apparently this is case-sensitive, and filter is registered as "Linear". This is a mistake, and should be fixed.

No, "filters" is a boolean for disabling filters selection.

Code: ags

[disabled]
linear

[disabled] section should still work, I think.

Yes, but with what value? Is there a manual page on the various things one can add in acsetup.cfg?

The actual ID of a filter:
https://adventuregamestudio.github.io/ags-manual/EngineConfigFile.html

[disabled] - special instructions for the setup program hinting to disable particular options or lock some in the certain state. Ignored by the engine.
render_at_screenres = [0; 1] - tells to lock "Render sprites in screen resolution" in a default state;
speechvox = [0; 1] - tells to lock "Use digital speech pack" in a default state;
filters = [0; 1] - tells to lock "Graphics filter" selection in a default state;
<filter id> - tells to remove particular graphics filter from the selection list;

The filter IDs are mentioned for the corresponding setting:

filter = [string] - id of the scaling filter to use. Supported filter names are:
none - run in native game size;
stdscale - nearest-neighbour scaling;
linear - anti-aliased scaling; not usable with software renderer.

For a game that formerly used the [disabled] section in acsetup.cfg to hide the AA filters, is it possible to hide the linear filter in a similar way?

[disabled] section should still work, I think.

Is it correct that the Hq2x and Anti-alias scaling methods no longer exist? I don't particularly miss them but wanted to doublecheck.

Hqx filter was dropped, Anti-alias is still there and renamed to "Linear filter".

They were software based (only worked in direct draw renderer or something), so they were dropped to favor the hardware accelerated renderers.

Hqx was dropped because in software mode the game scaling is now done by accelerated scaling of a single texture by SDL2.

And I see the setting for threaded audio is gone (by release history, it looks like it was reimplemented and is now on by default?) and the settings for MIDI device are also gone (probably as a result of including TIMIDITY with AGS, is that correct?)

Audio subsystem was completely rewritten, and audio thread is now enforced, except on Web port where threads do not work well for some reason.
MIDI device setting was removed because it became inapplicable with the new system. Everything is using same audio device now.

Wouldn't it be oFirstObject rather than cFirstObject

Right, fixed.

Controls do not exist on their own, but are placed on a parent GUI. Therefore there's no global array of ListBoxes (or Buttons, etc), and if you are using indexes, then you would need to also supply a parent GUI's ID.

Code: ags

function list_box_control(int parent_id, int lstb_id) {
    GUIControl *control = gui[parent_id].Controls[lstb_id];
    ListBox *listbox = control.AsListBox;
    listbox.Visible = !listbox.Visible; // this will toggle its current value
}

But, could you explain more, why do you want to use IDs, and not names, what is the use case here?

[at the same time]

Playing 2 animations at the same time would require to call the first Animate with eNoBlock.

Code: ags

    // replace with your real object names and view names
    oFirstObject.SetView(VANIMATION1);
    oAnotherObject.SetView(VANIMATION2);
    oFirstObject.Animate(0, eOnce, eNoBlock);
    oAnotherObject.Animate(0, eOnce, eBlock);

This will schedule first animation and immediately continue to the next command.

I do recommend using scriptnames for objects and views instead of their indexes, as that's safer and less prone to errors.

Fair enough. Is it easy to analyze two audio.vox files (one from 3.3, one from 3.6) to figure out files are in the former but not the latter?

We have a tool that unpacks ags archives, it's not "officially" distributed yet, but may be got from here:
https://www.dropbox.com/s/6wfl3foo3jb9iyu/agstools-360.zip?dl=0

The program is called "agsunpak", it is run from command line and unpacks the contents of any ags package into a directory.

When I build A Tale of Two Kingdoms with AGS 3.6, I get a much smaller Audio.vox file (74 Mb instead of 112 Mb).

It's not a problem since the older audio.vox file still works, but I'd like to know what might be the cause for that?

audio.vox is simply an archive with no compression of its own. If it's smaller, this means that less data is put into it: less files, or files are smaller.

audio.vox is built from audio clips that are
- marked as "put in audio vox" in their audio folder settings;
- found in AudioCache folder.

FIle appear in AudioCache when Editor can find source files, mentioned in the clip's property ("SourceFilename", or something similar).

[void]

Oh interesting. It appears this is bug is far less generalized that I had guessed. I'll run through a few different coding scenarios until I figure out which one it can be reproduced with.

Edit: I've tried to replicate this with a new/empty test project with the same kind of code, and I cannot replicate it. Would you mind if I zipped up my project folder and sent it to you via PM? I can point out how to reproduce it using my project.

I managed to replicate this with certain code, but only after I copied lots of your code over (struct definitions, etc). My attempts to replicate this in a smaller environment failed consistently.

This is definitely a compiler's error, but not an obvious one, it fails to track element access correctly at some point, maybe it cannot handle more complicated script.

The new compiler by fernewelten, which we use in ags4, does not have this problem, it points out the scripting mistake.

Using new compiler I found multiple other syntax mistakes in your game's script, so that's not the only issue: non-optional args following optional args (with default value), comparing non-managed object to null, comparing void function return value to an integer, and so on.
Old compiler misses all these for some reason.

Too bad the new compiler has its own problems, where things that were supposed to work with old compiler normally don't work anymore. For instance, it no longer can print char[n] array as a string into String.Format. I might report these as mistakes. But I think there are workarounds for all of these cases.

Hmm, that's strange. I'm not using any gamepads, and I've tested it on different PCs. It also works on Chrome, Safari, etc. Is there a way to exclude gamepads in the scripts at some point?

It's not your problem, it's the engine's issue, it has to be fixed in the engine.