New AGS site release

Started by AGA, Sun 19/01/2025 00:03:56

Previous topic - Next topic

AGA

Quote from: Kara Jo Kalinowski on Sat 01/02/2025 16:54:54With the new site, I uploaded a game yesterday, and I wanted to link to my google drive in the downloads, and it works from my PC where I am logged in, but both from my phone and from the person's computer that was helping me, the download link doesn't work (I think it's expecting a direct link to the zip and thus the redirect isn't working?). I also want to edit my submission, but clicking save isn't saving my edits.

Quote from: EmmaGundersen on Fri 31/01/2025 20:50:56Here's a video. I'm just trying to replace one .png with another and it won't let me save, but the same goes for any other kind of changes, even editing the description.

I'm not sure what's happening here.  @EmmaGundersen following the steps you did in your video succeeds for me!  Could @Kara Jo Kalinowski and @EmmaGundersen please both try again, with the web developer console open?  Press F12 and click the Console tab.  Then click the delete icon immediately before trying to use the form.  This will give us feedback from JavaScript, which is the only remaining cause I can think of here.  Please paste any output from the console here.

EmmaGundersen

Quote from: AGA on Sat 01/02/2025 21:20:05I'm not sure what's happening here.  @EmmaGundersen following the steps you did in your video succeeds for me!  Could @Kara Jo Kalinowski and @EmmaGundersen please both try again, with the web developer console open?  Press F12 and click the Console tab.  Then click the delete icon immediately before trying to use the form.  This will give us feedback from JavaScript, which is the only remaining cause I can think of here.  Please paste any output from the console here.


Uncaught TypeError: Cannot use 'in' operator to search for 'title' in undefined
    at findFormDataDifferences (game-add-edit.min.js:1:15742)
    at validateSubmission (game-add-edit.min.js:1:15103)
    at HTMLFormElement.<anonymous> (game-add-edit.min.js:1:14956)

AGA

Quote from: EmmaGundersen on Sat 01/02/2025 22:33:24
Quote from: AGA on Sat 01/02/2025 21:20:05I'm not sure what's happening here.  @EmmaGundersen following the steps you did in your video succeeds for me!  Could @Kara Jo Kalinowski and @EmmaGundersen please both try again, with the web developer console open?  Press F12 and click the Console tab.  Then click the delete icon immediately before trying to use the form.  This will give us feedback from JavaScript, which is the only remaining cause I can think of here.  Please paste any output from the console here.


Uncaught TypeError: Cannot use 'in' operator to search for 'title' in undefined
    at findFormDataDifferences (game-add-edit.min.js:1:15742)
    at validateSubmission (game-add-edit.min.js:1:15103)
    at HTMLFormElement.<anonymous> (game-add-edit.min.js:1:14956)

Thank you, that gives me something to work with!  I'll let you know when I've got a fix ready.

Kara Jo Kalinowski

#83
Quote from: AGA on Sat 01/02/2025 22:51:19
Quote from: EmmaGundersen on Sat 01/02/2025 22:33:24
Quote from: AGA on Sat 01/02/2025 21:20:05I'm not sure what's happening here.  @EmmaGundersen following the steps you did in your video succeeds for me!  Could @Kara Jo Kalinowski and @EmmaGundersen please both try again, with the web developer console open?  Press F12 and click the Console tab.  Then click the delete icon immediately before trying to use the form.  This will give us feedback from JavaScript, which is the only remaining cause I can think of here.  Please paste any output from the console here.

Thank you, that gives me something to work with!  I'll let you know when I've got a fix ready.


For me the error is

Uncaught TypeError: right-hand side of 'in' should be an object, got undefined
    findFormDataDifferences https://www.adventuregamestudio.co.uk/site/assets/js/game-add-edit.min.js:1
    validateSubmission https://www.adventuregamestudio.co.uk/site/assets/js/game-add-edit.min.js:1
    addGameAddEditFormListeners https://www.adventuregamestudio.co.uk/site/assets/js/game-add-edit.min.js:1
    at findFormDataDifferences (game-add-edit.min.js:1:15742)
    at validateSubmission (game-add-edit.min.js:1:15103)
    at HTMLFormElement.<anonymous> (game-add-edit.min.js:1:14956)

AGA

Those are both the same issue, just represented differently by your browsers.  I've uploaded something that will hopefully fix it.  If it continues to go wrong, you should get an obvious popup on your screen.

Please be sure to hard refresh the game's page screen with CTRL+SHIFT+R before retrying to ensure the JavaScript is reloaded.

Kara Jo Kalinowski

#85
Quote from: AGA on Sun 02/02/2025 00:13:00Those are both the same issue, just represented differently by your browsers.  I've uploaded something that will hopefully fix it.  If it continues to go wrong, you should get an obvious popup on your screen.

Please be sure to hard refresh the game's page screen with CTRL+SHIFT+R before retrying to ensure the JavaScript is reloaded.

It's not fixed for me. I've tried it in 3 browsers.

AGA

Okay, I think I've fixed the issue.  Please hard refresh and try again.  Fingers crossed it'll work!

Kara Jo Kalinowski

Did a hard refresh (control+F5 in firefox) and it works!

EmmaGundersen

Quote from: AGA on Sun 02/02/2025 12:06:02Okay, I think I've fixed the issue.  Please hard refresh and try again.  Fingers crossed it'll work!

It worked for me too!

Kara Jo Kalinowski

One feedback I have with the site design in general (it's been this way since the old site) is that I think that there should be a direct "Forum" link that takes you to the main page without needing to navigate through multiple pages. The submenus aren't that big of a deal, but there's only links to certain subforums like competitions and activities.

AGA

Quote from: Kara Jo Kalinowski on Mon 03/02/2025 15:51:46One feedback I have with the site design in general (it's been this way since the old site) is that I think that there should be a direct "Forum" link that takes you to the main page without needing to navigate through multiple pages. The submenus aren't that big of a deal, but there's only links to certain subforums like competitions and activities.

There's a big Enter the Forums button right at the top of this page: https://www.adventuregamestudio.co.uk/join/, which is one of the three main strands of the site.  Two clicks from the home page: one on Join, one on that button.

Something to bear in mind is that the vast majority of visitors to the site aren't here for the forums.  Most people come to play games rather than making them or seeking support.  Believe me, I've been seeing the user stats for the last 15 years!  While as a regular visitor to the forums it may seem a long way to go to get to where you want, you aren't necessarily representative of the entire user base.

Kara Jo Kalinowski

Quote from: AGA on Mon 03/02/2025 16:28:23
Quote from: Kara Jo Kalinowski on Mon 03/02/2025 15:51:46One feedback I have with the site design in general (it's been this way since the old site) is that I think that there should be a direct "Forum" link that takes you to the main page without needing to navigate through multiple pages. The submenus aren't that big of a deal, but there's only links to certain subforums like competitions and activities.

There's a big Enter the Forums button right at the top of this page: https://www.adventuregamestudio.co.uk/join/, which is one of the three main strands of the site.  Two clicks from the home page: one on Join, one on that button.

Something to bear in mind is that the vast majority of visitors to the site aren't here for the forums.  Most people come to play games rather than making them or seeking support.  Believe me, I've been seeing the user stats for the last 15 years!  While as a regular visitor to the forums it may seem a long way to go to get to where you want, you aren't necessarily representative of the entire user base.

Actually I realized if you scroll down enough there is a button too, not sure if that is in browser also or just mobile. I think that didn't exist in the old site.

heltenjon

I just posted some links to games in the AGS database as an answer to Kara Jo on discord. The thumbnail says "Game Not Found", although clicking on those very words brings me to the game page. I also discovered that the other window I had open, despite being on the game page in the database, when hovering, said "Game Not Found and 3 more pages". This seems to be the case no matter which game page I am on, so I guess the database send out the error message despite there being no error. (I am using Windows 11.)

heltenjon

Quote from: AGA on Sun 02/02/2025 12:06:02Okay, I think I've fixed the issue.  Please hard refresh and try again.  Fingers crossed it'll work!
I also had to do the hard refresh to edit a game as database admin (I removed a MAGS tag). If this is the permanent solution, perhaps we need an info box about it close to the save button?

AGA

Quote from: heltenjon on Tue 04/02/2025 18:08:11
Quote from: AGA on Sun 02/02/2025 12:06:02Okay, I think I've fixed the issue.  Please hard refresh and try again.  Fingers crossed it'll work!
I also had to do the hard refresh to edit a game as database admin (I removed a MAGS tag). If this is the permanent solution, perhaps we need an info box about it close to the save button?

I'm not sure what you mean here?  A hard refresh should only be required if there are JavaScript changes, which only happens when I fix a bug.  Day to day, it shouldn't ever be necessary.

Quote from: heltenjon on Tue 04/02/2025 10:24:53I just posted some links to games in the AGS database as an answer to Kara Jo on discord. The thumbnail says "Game Not Found", although clicking on those very words brings me to the game page. I also discovered that the other window I had open, despite being on the game page in the database, when hovering, said "Game Not Found and 3 more pages". This seems to be the case no matter which game page I am on, so I guess the database send out the error message despite there being no error. (I am using Windows 11.)

This should now be fixed!  Witness (https://www.adventuregamestudio.co.uk/play/game/785/) now shows the correct title, and only non-existent games (e.g. https://www.adventuregamestudio.co.uk/play/game/99999999/) show the Game Not Found title.

heltenjon

Quote from: AGA on Tue 04/02/2025 21:14:55I'm not sure what you mean here?  A hard refresh should only be required if there are JavaScript changes, which only happens when I fix a bug.  Day to day, it shouldn't ever be necessary.
Thanks, sorry to show my skillessness.  :)

brushfe

I'm not sure if this is intentional or a bug:

There's a banner at the top of the forums for the AGS Awards which invites me to visit its thread for more info.

However, when I click that link, I end up at the very latest post in the thread - which was very confusing for someone who was looking to understand how it worked, who was nominated, etc.

The banner is worded as though it was going to take me to an introduction/explanation of the awards, but maybe I'm misinterpreting that!

Crimson Wizard

I just randomly pressed "Edit Game" on a random game in database, and to my surprise it opened game description for editing. Is it a bug, or I somehow have permissions to do that (then why)?

Gilbert

Quote from: Crimson Wizard on Thu 06/02/2025 09:50:21I just randomly pressed "Edit Game" on a random game in database, and to my surprise it opened game description for editing. Is it a bug, or I somehow have permissions to do that (then why)?
Don't know whether this is intentional, but I think most (all?) mods on the forums are also mods of the game pages.
I seem to recall that before the site update I saw something like "You are an admin (moderator?) of the game pages" but it's no longer specified after the update.

AGA

Yeah, all forums staff and panel members have edit rights.

Not that it's ever likely to be an issue, but there's a full audit log of changes made to all games entries, so I can always roll back to the before-editing point if something went wrong.

SMF spam blocked by CleanTalk