New AGS site release

Started by AGA, Sun 19/01/2025 00:03:56

Previous topic - Next topic

cat

I just tried to add a comment to a game but it was not accepted. The input was just cleared, no error message or anything. I figured out it might be "" that I used in the comment. When I removed them, it worked.
I know that you have to sanitize your input (hello Bobby Tables), but it should be escaped or there should be at least some error message.

AGA

Quote from: heltenjon on Thu 13/03/2025 18:00:38
Quote from: heltenjon on Fri 28/02/2025 19:39:36Another one about database maintenance:
Tres Acordes had three download links: game, store and demo. All three was reported broken. As all three were identical, I deleted store and demo and replaced the game link with a working one. However, in the AGS site report thread, the result is that the two deleted links are still listed as errors. Is it possible to automatically mark these as fixes when deleted? (I guess a workaround would be to add false link, checkmark, then delete, but that would be cumbersome.)
This problem still exists - when deleting a download option, the tag marking that it has been reported still is active. Example

I'm working on this!

Quote from: Creamy on Sun 23/03/2025 09:21:18Just a suggestion: I think it'd be nice to have a button allowing comments to be edited and removed by their author in the game page.
It could be useful in case, you know, commentators fail to see their comment and accidentally post twice (roll)

We decided years ago not to allow users to edit or delete their comments to avoid revisionism, and people going back and changing their opinions after the fact.  Plus, honestly, it would be quite a bit of effort to implement, while asking a games page admin to delete a comment is relatively easy!

Quote from: cat on Mon 24/03/2025 20:34:19I just tried to add a comment to a game but it was not accepted. The input was just cleared, no error message or anything. I figured out it might be "" that I used in the comment. When I removed them, it worked.
I know that you have to sanitize your input (hello Bobby Tables), but it should be escaped or there should be at least some error message.

Should be fixed now!

Khris

Just a tiny cosmetic issue:

The favicon has a black background, as opposed to a transparent one:


Is this deliberate?

Danvzare

Quote from: Khris on Fri 28/03/2025 11:29:45Just a tiny cosmetic issue:

The favicon has a black background, as opposed to a transparent one:


Is this deliberate?
Presumably it's there to make the white outline visible.

Alternatively it'd have to look like this:


I'm not sure which looks better though.  :-\

cat

I think the only problem was, that no-one MADE a better icon. What about having the background blue as the cup itself?

brushfe

#145
I found a few unusual things while browsing the games section:

- The "actions" dropdown only had one action (report image as broken). Maybe other games have more actions, but a dropdown list with only one action seemed odd.
- It's also an unusual action to have as important in the UI as 'Download'.
- Below those two buttons, hidden in the list of game details, was 'Favourite'. This is another user action, so it also seemed odd that it wasn't in the dropdown list.

It might make more sense to have the two big buttons be Download and Favourite, since these are arguably the two most important ones for people browsing games. The less important and less used "report broken image" action could be a text link near "share your thoughts" or an icon integrated into the image browser.

Speaking of the image browser:

- On Firefox Android, the pause button often doesn't stop the progress bar when only one screenshot exists (it just resets and progresses again).
- After pressing the pause button, pressing it again (to try pausing it again) occasionally makes the image browser go full screen.
- When the pause button occasionally works, tapping the screenshot / holding it to scroll down will unpause the progress bar (or trigger full screen, as above)

If these are issues beyond my phone, one option could be to disable the progress bar when only one screenshot exists? And perhaps the ability to drag the image by holding it down?

Hopefully some of this is helpful! Thank you for making the new AGS site so great!

AGA

#146
Quote from: cat on Fri 28/03/2025 12:28:43I think the only problem was, that no-one MADE a better icon. What about having the background blue as the cup itself?

Blue or one of the other colours in the light theme colour palette might work best, as otherwise you have to contend with every browser (and OS theme) having a different background colour for a tab (which having a transparent background could end up clashing with (e.g. white outline on a white tab)).

OR have a light theme version with a certain background, and a dark theme one with another.  I could then dynamically serve a different favicon depending on the selected theme.

cat

Ok, I will give it a try.
What is the best way of creating an icon? Which tools can be used? Last time I did this it required several bitmaps in various resolutions and color depths to be included in one file. Has this changed?

RootBound

Quote from: cat on Sat 29/03/2025 16:41:21Ok, I will give it a try.
What is the best way of creating an icon? Which tools can be used? Last time I did this it required several bitmaps in various resolutions and color depths to be included in one file. Has this changed?

There's a website called "convertio" that can convert a bitmap or png to an icon, so if you just create the highest resolution, the converter takes care of the rest. Just Google "png to ico" and it should come up.
They/them. Here are some of my games:

heltenjon

There seems to be a problem with the database. When I try to edit a game, it leads to a blank screen instead of the edit screen. And when opening the "Search all games" page, no game is found until I add a search parameter or a filter. (Previously - all games were listed when no parameter was given.)

AGA

Should be solved now!

cat

I gave it a try with convertio but the icon doesn't seem to fully work. It doesn't show up in list or details view in explorer but in the larger views. Here is the png, if anyone wants to give it a try:




(and here is the icon I generated ico and the super ugly svg: svg)

Danvzare

Quote from: cat on Thu 03/04/2025 21:00:05I gave it a try with convertio but the icon doesn't seem to fully work. It doesn't show up in list or details view in explorer but in the larger views. Here is the png, if anyone wants to give it a try:

Here you go:


It's got the sizes: 256, 128, 48, 32, and 16.
I made it using Gimp, although I did the resizing with IrfanView in order to use the Lanczos resampler, since I think it's the best resampler for retaining details.

AGA

Quote from: Danvzare on Fri 04/04/2025 12:14:29
Quote from: cat on Thu 03/04/2025 21:00:05I gave it a try with convertio but the icon doesn't seem to fully work. It doesn't show up in list or details view in explorer but in the larger views. Here is the png, if anyone wants to give it a try:

Here you go:


It's got the sizes: 256, 128, 48, 32, and 16.
I made it using Gimp, although I did the resizing with IrfanView in order to use the Lanczos resampler, since I think it's the best resampler for retaining details.

Looks great on light mode!  Any chance of a version with a transparent background for dark mode, please?  So the cup with white outline, but no blue background, just transparent instead.

Danvzare

Quote from: AGA on Sat 05/04/2025 10:26:35Looks great on light mode!  Any chance of a version with a transparent background for dark mode, please?  So the cup with white outline, but no blue background, just transparent instead.

How's this?

AGA

Great!  On the main site it will now switch between the blue backgrounded version on light theme, and transparent on dark.

There's a bit more work required to get it working on the forums, bear with me.

cat

Wouldn't the blue background alse work for the dark mode?

trevbot

Hi not sure if this is the right place to mention this, but when I'm on the site www.adventuregamestudio.co.uk/play/search/ any of the games I click on bring me to a blank page (each with a path like /play/game/1234/).

I'm not sure if this is the "new site" or if I'm looking in the wrong place.

Anyway seems to be a 100% reproduction rate. I'm using Edge, haven't tested with other browsers.

AGA

Quote from: cat on Sat 05/04/2025 14:51:53Wouldn't the blue background alse work for the dark mode?

If you have dark mode in your OS too, your browser tabs can also be dark (black for unfocused, grey for focused on Firefox for instance).  The blue clashes a bit then, but transparent looks really nice on both black and grey in my opinion.

Quote from: trevbot on Sun 06/04/2025 18:13:56Hi not sure if this is the right place to mention this, but when I'm on the site www.adventuregamestudio.co.uk/play/search/ any of the games I click on bring me to a blank page (each with a path like /play/game/1234/).

I'm not sure if this is the "new site" or if I'm looking in the wrong place.

Anyway seems to be a 100% reproduction rate. I'm using Edge, haven't tested with other browsers.

Fixed, thanks!

heltenjon

On the front game page, https://www.adventuregamestudio.co.uk/play/ , Under Most recent games, it looks like games without working thumbnails are not listed. (Rosewater is most recent game, and it does not show up here.)

SMF spam blocked by CleanTalk